Skip to content

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Aug 1, 2023

Fixes #131415

We should do an audit of all such cases though, filed #131678

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 1, 2023
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 1, 2023
@auto-submit auto-submit bot merged commit c571698 into flutter:master Aug 1, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2023
@dnfield dnfield deleted the cb branch August 1, 2023 20:01
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2023
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
camsim99 pushed a commit to flutter/packages that referenced this pull request Aug 2, 2023
Roll Flutter from 1d59196 to b3f99ff (32 revisions)

flutter/flutter@1d59196...b3f99ff

2023-08-02 [email protected] Fix reentrancy with WidgetBindingObserver
callbacks (flutter/flutter#131774)
2023-08-02 [email protected] Update .ci.yaml
to add new shard to prevent timeouts (flutter/flutter#131712)
2023-08-02 [email protected] Fix flex methods for min and max column
widths (flutter/flutter#131724)
2023-08-02 [email protected] Manual roll Flutter Engine
from 9dae7b708bda to d6b962d0e36d (25 revisions)
(flutter/flutter#131785)
2023-08-02 [email protected] Added standard
deviation to rasterizer results. (flutter/flutter#131781)
2023-08-02 [email protected] Tiny remove outdated
comments (flutter/flutter#130387)
2023-08-02 49699333+dependabot[bot]@users.noreply.github.com Bump ubuntu
from `f8f6584` to `c9820a4` in /dev/ci/docker_linux
(flutter/flutter#130292)
2023-08-02 [email protected] Fix for endless recursion for
getLayoutExplorerNode on a Tooltip (flutter/flutter#131486)
2023-08-02 49699333+dependabot[bot]@users.noreply.github.com Bump
google/mirror-branch-action from 1.0 to 2.0 (flutter/flutter#126600)
2023-08-02 49699333+dependabot[bot]@users.noreply.github.com Bump
dessant/lock-threads from 4.0.0 to 4.0.1 (flutter/flutter#128741)
2023-08-02 49699333+dependabot[bot]@users.noreply.github.com Bump
codecov/codecov-action from 3.1.3 to 3.1.4 (flutter/flutter#126885)
2023-08-02 [email protected] Update `ThemeData`'s factory method
documents (flutter/flutter#123984)
2023-08-02 [email protected] Fix Scrollable `TabBar` for Material 3
(flutter/flutter#131409)
2023-08-02 [email protected] ImageProvider.toString uses
double.toStringAsFixed (flutter/flutter#131348)
2023-08-02 [email protected] Roll Flutter Engine from
10a1f9cb74c9 to 9dae7b708bda (4 revisions) (flutter/flutter#131706)
2023-08-01 [email protected] Upgrade Flutter libraries.
(flutter/flutter#131700)
2023-08-01 [email protected] Roll Flutter Engine from
1aadc75dd5a7 to 10a1f9cb74c9 (1 revision) (flutter/flutter#131696)
2023-08-01 [email protected] Roll Flutter Engine from
e3f817ce9953 to 1aadc75dd5a7 (2 revisions) (flutter/flutter#131691)
2023-08-01 [email protected] Roll Packages from
60e9a54 to 3dc00c1 (5 revisions) (flutter/flutter#131692)
2023-08-01 [email protected] Avoid concurrent modification of
persistent frame callbacks (flutter/flutter#131677)
2023-08-01 [email protected] Roll Flutter Engine from
ae535c024146 to e3f817ce9953 (1 revision) (flutter/flutter#131687)
2023-08-01 [email protected] Roll Flutter Engine from
703d45539059 to ae535c024146 (4 revisions) (flutter/flutter#131679)
2023-08-01 [email protected] Roll Flutter Engine from
f1c80ce98499 to 703d45539059 (1 revision) (flutter/flutter#131668)
2023-08-01 [email protected] Roll Flutter Engine from
2583c07f6a69 to f1c80ce98499 (1 revision) (flutter/flutter#131663)
2023-08-01 [email protected] Roll Flutter Engine from
25b9d1088d09 to 2583c07f6a69 (1 revision) (flutter/flutter#131661)
2023-08-01 [email protected] Roll Flutter Engine from
7651b3cba6ba to 25b9d1088d09 (4 revisions) (flutter/flutter#131655)
2023-08-01 [email protected] Roll Flutter Engine from
1433e23c8a3d to 7651b3cba6ba (2 revisions) (flutter/flutter#131648)
2023-08-01 [email protected] Roll Flutter Engine from
791f505c8c6e to 1433e23c8a3d (1 revision) (flutter/flutter#131647)
2023-08-01 [email protected] Roll Flutter Engine from
bb2a903c934c to 791f505c8c6e (4 revisions) (flutter/flutter#131645)
2023-08-01 [email protected] 🐛 Treat empty ARB content as empty map
when decoding (flutter/flutter#131242)
2023-08-01 [email protected] Roll Flutter Engine from
fe2369565f59 to bb2a903c934c (3 revisions) (flutter/flutter#131639)
2023-07-31 [email protected] Roll Flutter Engine from
b83172a4e995 to fe2369565f59 (12 revisions) (flutter/flutter#131638)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
[email protected],[email protected],[email protected] on
the revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
...
@goderbauer
Copy link
Member

We should probably also update the docs on addPersistentFrameCallback to be explicit that callbacks registered while the iteration is in progress will not be called for the current frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flutter app throws so many exceptions about concurrent modification during iteration of a GrowableList

3 participants