-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Fix PopupMenuItem & CheckedPopupMenuItem has redundant ListTile padding and update default horizontal padding for Material 3
#131609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
auto-submit
merged 1 commit into
flutter:master
from
TahaTesser:pop_up_menu_item_padding
Aug 10, 2023
Merged
Fix PopupMenuItem & CheckedPopupMenuItem has redundant ListTile padding and update default horizontal padding for Material 3
#131609
auto-submit
merged 1 commit into
flutter:master
from
TahaTesser:pop_up_menu_item_padding
Aug 10, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c144ecf to
09ff4fa
Compare
This comment was marked as resolved.
This comment was marked as resolved.
09ff4fa to
01fe678
Compare
This comment was marked as resolved.
This comment was marked as resolved.
16 tasks
293037d to
41005cc
Compare
Member
Author
|
This is ready for review @QuncCccccc |
… padding and update default horizontal padding for Material 3
41005cc to
dda92fa
Compare
HansMuller
approved these changes
Aug 10, 2023
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm going to land this. It's possible that it will cause some golden image tests to fail, although the presubmits are all happy.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2023
…istTile` padding and update default horizontal padding for Material 3 (flutter/flutter#131609)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2023
…istTile` padding and update default horizontal padding for Material 3 (flutter/flutter#131609)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2023
…istTile` padding and update default horizontal padding for Material 3 (flutter/flutter#131609)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2023
…istTile` padding and update default horizontal padding for Material 3 (flutter/flutter#131609)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2023
…istTile` padding and update default horizontal padding for Material 3 (flutter/flutter#131609)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2023
…istTile` padding and update default horizontal padding for Material 3 (flutter/flutter#131609)
2 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
…istTile` padding and update default horizontal padding for Material 3 (flutter/flutter#131609)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a: internationalization
Supporting other languages or locales. (aka i18n)
a: text input
Entering text in a text field or keyboard related problems
autosubmit
Merge PR when tree becomes green via auto submit App
f: material design
flutter/packages/flutter/material repository.
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes
PopupMenuItemadds redundant padding when usingListItemDescription
ListTilepadding when usingCheckedPopupMenuItemorPopupMenuItemwith theListTilechild for complex popup menu items as suggested in the docs.Code sample
expand to view the code sample
Before
ListTilenested by default inCheckedPopupMenuItemhas redundant paddingPopupMenuItemusingListTileas a child for complex menu items contains redundant padding.After
PopupMenuItem&CheckedPopupMenuItemoverrideListTilepadding (similar to howExpansionTileoverridesListTiletext and icon color.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.