Reland --omit-type-checks for benchmarks. #131493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
approved these changes
Jul 28, 2023
eyebrowsoffire
added
the
autosubmit
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
Because the cost of type checks dominate our dart2wasm benchmarks, we've decided to pass `--omit-type-checks` for now. This was previously reverted because the skwasm benchmarks were broken in general for a separate reason, and my getting rid of `bringup: true` broke the tree. I ended up fixing the benchmarks and getting rid of `bringup: true` in a separate commit, so this just adds the flag only.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 31, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 1, 2023
Manual roll requested by [email protected] flutter/flutter@1d44fbd...1d59196 2023-07-31 [email protected] Appended period remove & Uri parsing fix. (flutter/flutter#131293) 2023-07-31 [email protected] Fixed regex to show missing assets file error (flutter/flutter#131160) 2023-07-31 [email protected] Update `CheckboxListTile` and `CalendarDatePicker` tests for M2/M3 (flutter/flutter#131363) 2023-07-31 [email protected] Reland --omit-type-checks for benchmarks. (flutter/flutter#131493) 2023-07-31 [email protected] Update the cirrus key jul-31-2023 (flutter/flutter#131624) 2023-07-31 [email protected] Add Expanded/Collapsed State for Semantics (flutter/flutter#131233) 2023-07-31 [email protected] Reland - "Update Unit Tests for M2/M3" (flutter/flutter#131504) 2023-07-31 [email protected] Roll Flutter Engine from ae6d1d60df95 to b83172a4e995 (4 revisions) (flutter/flutter#131614) 2023-07-31 [email protected] Upgrade compile and target sdk versions in tests and benchmarks (flutter/flutter#131428) 2023-07-31 [email protected] Roll Flutter Engine from b11a832ea7d4 to ae6d1d60df95 (1 revision) (flutter/flutter#131611) 2023-07-31 [email protected] Roll Packages from 10aab44 to 60e9a54 (6 revisions) (flutter/flutter#131607) 2023-07-31 [email protected] Fix dartdoc for `ButtonSegment` constructor (flutter/flutter#131400) 2023-07-31 [email protected] [flutter_tools/dap] Improve rendering of structured errors via DAP (flutter/flutter#131251) 2023-07-31 [email protected] [doc] Fix module_test_ios comments (flutter/flutter#131470) 2023-07-31 [email protected] Use Flutter app project's NDK version from FFI plugin (flutter/flutter#131141) 2023-07-31 [email protected] Roll Flutter Engine from 22f9aad5aba5 to b11a832ea7d4 (2 revisions) (flutter/flutter#131597) 2023-07-31 [email protected] Roll Flutter Engine from b84c93601684 to 22f9aad5aba5 (3 revisions) (flutter/flutter#131592) 2023-07-31 [email protected] Roll Flutter Engine from d95adb9c8bc6 to b84c93601684 (1 revision) (flutter/flutter#131585) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Member
|
SkiaPerf is reporting both improvements and regressions on this change: |
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
Because the cost of type checks dominate our dart2wasm benchmarks, we've decided to pass `--omit-type-checks` for now. This was previously reverted because the skwasm benchmarks were broken in general for a separate reason, and my getting rid of `bringup: true` broke the tree. I ended up fixing the benchmarks and getting rid of `bringup: true` in a separate commit, so this just adds the flag only.
Contributor
Author
|
The "regressions" are just changes in the outlierRatio, which I think is just a reflection of the fact that the average went down so much for those benchmarks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the cost of type checks dominate our dart2wasm benchmarks, we've decided to pass
--omit-type-checksfor now.This was previously reverted because the skwasm benchmarks were broken in general for a separate reason, and my getting rid of
bringup: truebroke the tree. I ended up fixing the benchmarks and getting rid ofbringup: truein a separate commit, so this just adds the flag only.