Skip to content

Conversation

@jonahwilliams
Copy link
Contributor

Fixes #130524

loadBuffer was superseded by loadImage

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 27, 2023
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 27, 2023
@auto-submit auto-submit bot merged commit 46d0740 into flutter:master Jul 27, 2023
@jonahwilliams jonahwilliams deleted the fix_deprecations_for_image_loading branch July 27, 2023 23:27
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 28, 2023
flutter/flutter@dd9764e...e81907e

2023-07-28 [email protected] Update Chrome to 115, and remove `bringup: true` from skwasm benchmarks. (flutter/flutter#131430)
2023-07-28 [email protected] Fix `TimePicker` defaults for `hourMinuteTextStyle` and `dayPeriodTextColor` for Material 3 (flutter/flutter#131253)
2023-07-28 [email protected] Roll Flutter Engine from cfa5427dc452 to e97014c71014 (3 revisions) (flutter/flutter#131477)
2023-07-28 [email protected] Roll Flutter Engine from dc8618da9eb0 to cfa5427dc452 (3 revisions) (flutter/flutter#131464)
2023-07-28 [email protected] Roll Flutter Engine from b0d97ba45f46 to dc8618da9eb0 (3 revisions) (flutter/flutter#131460)
2023-07-28 [email protected] Updated integration_tests/platform_interaction test_step.dart (flutter/flutter#131301)
2023-07-28 [email protected] Roll Flutter Engine from 0713d91c2e64 to b0d97ba45f46 (1 revision) (flutter/flutter#131453)
2023-07-28 [email protected] Roll Flutter Engine from 01bb0a3ef922 to 0713d91c2e64 (2 revisions) (flutter/flutter#131451)
2023-07-28 [email protected] Roll Flutter Engine from 196474bd96b0 to 01bb0a3ef922 (3 revisions) (flutter/flutter#131447)
2023-07-27 [email protected] Roll Flutter Engine from 284771da323c to 196474bd96b0 (3 revisions) (flutter/flutter#131443)
2023-07-27 [email protected] [framework] clean up image provider documentation. (flutter/flutter#131416)
2023-07-27 [email protected] Fix template app documentation (flutter/flutter#131125)
2023-07-27 [email protected] Roll Flutter Engine from 9a935ecbf73a to 284771da323c (3 revisions) (flutter/flutter#131439)
2023-07-27 [email protected] â�¡ï¸� Add `ssh://[email protected]/flutter/flutter.git` as a standard remote (flutter/flutter#131333)
2023-07-27 [email protected] Roll Flutter Engine from f3317dbab388 to 9a935ecbf73a (1 revision) (flutter/flutter#131437)
2023-07-27 [email protected] ð��� Only format Dart files for `gen-l10n` (flutter/flutter#131232)
2023-07-27 [email protected] Roll Flutter Engine from 08050cdecf94 to f3317dbab388 (1 revision) (flutter/flutter#131432)
2023-07-27 [email protected] Preliminary PR for engine changes for Expanded/Collapsed Submenu button (flutter/flutter#131359)
2023-07-27 [email protected] Roll Flutter Engine from 9b14c382eebf to 08050cdecf94 (22 revisions) (flutter/flutter#131426)
2023-07-27 [email protected] Roll Packages from a99fc87 to f4ae933 (3 revisions) (flutter/flutter#131422)
2023-07-27 [email protected] Manual roll to engine commit 9b14c382 using Dart SDK version 3.2.x (flutter/flutter#131371)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ImageProvider hierarchy has very confused documentation

2 participants