PaginatedDataTable improvements #131374
Merged
PaginatedDataTable improvements #131374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: tests
Hixie
force-pushed
the
paginateddatatable1
branch
5 times, most recently
from
9eeb318 to
53cf6fe
Compare
Hixie
force-pushed
the
paginateddatatable1
branch
from
53cf6fe to
9668829
Compare
Hixie
force-pushed
the
paginateddatatable1
branch
2 times, most recently
from
299c075 to
6dc3bc4
Compare
Hixie
force-pushed
the
paginateddatatable1
branch
from
6dc3bc4 to
5766895
Compare
HansMuller
approved these changes
Aug 14, 2023
Contributor
There was a problem hiding this comment.
Overriding this method is pretty rare (I think Image is the only other widget that does it). A comment explaining the what and why would be helpful.
Contributor
There was a problem hiding this comment.
NICE, more interesting than I expected!
Hixie
force-pushed
the
paginateddatatable1
branch
from
5766895 to
8a6cd7c
Compare
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/131374, due to - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label. |
- slightly improved assert message when row cell counts don't match column count. - more breadcrumbs in API documentation. more documentation in general. - added more documentation for the direction of the "ascending" arrow. - two samples for PaginatedDataTable. - make PaginatedDataTable support hot reloading across changes to the number of columns. - introduce matrix3MoreOrLessEquals. An earlier version of this PR used it in tests, but eventually it was not needed. The function seems useful to keep though.
Hixie
force-pushed
the
paginateddatatable1
branch
from
8a6cd7c to
48479ca
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 16, 2023
Manual roll Flutter from 9b6945b to f0e7c51 (63 revisions) Manual roll requested by [email protected] flutter/flutter@9b6945b...f0e7c51 2023-08-15 [email protected] Upgrade flutter packages. (flutter/flutter#132585) 2023-08-15 [email protected] [integration_test] Update outdated onScreenshot signature in README code snippet (flutter/flutter#132409) 2023-08-15 [email protected] Roll Flutter Engine from 0760b5589c71 to 22f03ffdc290 (1 revision) (flutter/flutter#132580) 2023-08-15 [email protected] Make completeError be a proper JS function (flutter/flutter#132492) 2023-08-15 [email protected] Analyze code snippets in flutter_driver docs (flutter/flutter#132337) 2023-08-15 [email protected] Skip backfiller for docs_publish (flutter/flutter#132510) 2023-08-15 [email protected] Further clarification of the TextSelectionControls migration (flutter/flutter#132539) 2023-08-15 [email protected] Roll Packages from 08080ab to 84218b9 (1 revision) (flutter/flutter#132572) 2023-08-15 [email protected] Roll Flutter Engine from 2c90670171a7 to 0760b5589c71 (1 revision) (flutter/flutter#132570) 2023-08-15 [email protected] Update `flutter_tools` internals related to Gradle/XCode to set `--local-engine-host`. (flutter/flutter#132346) 2023-08-15 [email protected] Roll Flutter Engine from 6bd7b717e110 to 2c90670171a7 (2 revisions) (flutter/flutter#132566) 2023-08-15 [email protected] Roll Flutter Engine from 9091107e594d to 6bd7b717e110 (1 revision) (flutter/flutter#132561) 2023-08-15 [email protected] Roll Flutter Engine from a17130ac4d49 to 9091107e594d (2 revisions) (flutter/flutter#132553) 2023-08-15 [email protected] Roll Flutter Engine from 6975ee1b6de7 to a17130ac4d49 (5 revisions) (flutter/flutter#132550) 2023-08-15 [email protected] Roll Flutter Engine from 21aed05ad751 to 6975ee1b6de7 (1 revision) (flutter/flutter#132543) 2023-08-15 [email protected] Manual roll of docker focal version. (flutter/flutter#132536) 2023-08-15 [email protected] Roll Flutter Engine from f1f912c0c7c7 to 21aed05ad751 (1 revision) (flutter/flutter#132540) 2023-08-15 [email protected] PaginatedDataTable improvements (flutter/flutter#131374) 2023-08-15 [email protected] Roll Flutter Engine from 1d63eece6c37 to f1f912c0c7c7 (2 revisions) (flutter/flutter#132538) 2023-08-15 [email protected] [devicelab] fix name of flutter driver benchmark. (flutter/flutter#132527) 2023-08-14 [email protected] Roll Flutter Engine from 3c8852827646 to 1d63eece6c37 (1 revision) (flutter/flutter#132534) 2023-08-14 [email protected] Updates `AutomatedTestWidgetsFlutterBinding.pump` to support microsecond precision (flutter/flutter#132401) 2023-08-14 [email protected] Roll Flutter Engine from 785b24900a36 to 3c8852827646 (2 revisions) (flutter/flutter#132530) 2023-08-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.3 to 2.21.4 (flutter/flutter#132525) 2023-08-14 [email protected] [devicelab] fix NAN/Inf in drawPoints benchmark. (flutter/flutter#132526) 2023-08-14 [email protected] Selection area should move selection word by word on a long press drag (flutter/flutter#132518) 2023-08-14 [email protected] Roll Flutter Engine from 56a0e2715dca to 785b24900a36 (10 revisions) (flutter/flutter#132522) 2023-08-14 [email protected] [flutter_tools] hide Skia specific rendering options. (flutter/flutter#132509) 2023-08-14 [email protected] Update menu examples for `SafeArea` (flutter/flutter#132390) 2023-08-14 [email protected] Update `dev/bots/test.dart` (and friends) to provide `--local-engine-host`. (flutter/flutter#132354) 2023-08-14 [email protected] Roll Flutter Engine from 46c11916f8d2 to 56a0e2715dca (2 revisions) (flutter/flutter#132508) 2023-08-14 [email protected] [devicelab] boot up benchmarks. (flutter/flutter#132148) 2023-08-14 [email protected] Roll Packages from 9b15c2e to 08080ab (5 revisions) (flutter/flutter#132505) 2023-08-14 [email protected] Roll Flutter Engine from c125e1e23d4b to 46c11916f8d2 (1 revision) (flutter/flutter#132502) 2023-08-14 [email protected] Fix log filtering and CI tests for iOS 17 physical devices (flutter/flutter#132491) 2023-08-14 [email protected] Roll Flutter Engine from 4e8b2b61f648 to c125e1e23d4b (1 revision) (flutter/flutter#132496) 2023-08-14 [email protected] Unpin leak_tracker and handle breaking changes in API. (flutter/flutter#132352) 2023-08-14 [email protected] Roll Flutter Engine from 62a392f29aa5 to 4e8b2b61f648 (2 revisions) (flutter/flutter#132490) 2023-08-14 [email protected] Roll Flutter Engine from f50ad637de75 to 62a392f29aa5 (1 revision) (flutter/flutter#132487) 2023-08-14 [email protected] Roll Flutter Engine from 9cebd2015688 to f50ad637de75 (3 revisions) (flutter/flutter#132480) 2023-08-14 [email protected] Roll Flutter Engine from bcaaa0e125fe to 9cebd2015688 (2 revisions) (flutter/flutter#132477) 2023-08-14 [email protected] Roll Flutter Engine from 7915c049a1fd to bcaaa0e125fe (1 revision) (flutter/flutter#132473) 2023-08-14 [email protected] Roll Flutter Engine from f47e864f2dcb to 7915c049a1fd (1 revision) (flutter/flutter#132466) 2023-08-13 [email protected] Revert "Fix `PopupMenuItem` & `CheckedPopupMenuItem` has redundant `ListTile` padding and update default horizontal padding for Material 3" (flutter/flutter#132457) ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.