Skip to content

Conversation

@loic-sharma
Copy link
Member

Reverts #131292

This PR is affected by https://g-issues.skia.org/issues/40045533.

See @Piinks's explanation:

The mirror is probably out of sync. The failing commit introduced new changes, but they have not been updated yet. I would revert the PR until we can check the mirror. Last week it went 2+ hours out of sync so rerunning it may not green the tree for a while.

@loic-sharma loic-sharma requested a review from QuncCccccc July 26, 2023 22:45
@loic-sharma loic-sharma added warning: land on red to fix tree breakage revert Autorevert PR (with "Reason for revert:" comment) labels Jul 26, 2023
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 26, 2023
@auto-submit auto-submit bot merged commit f359d9e into master Jul 26, 2023
@auto-submit auto-submit bot deleted the revert-131292-update_material3_tests branch July 26, 2023 22:46
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 27, 2023
tarrinneal pushed a commit to flutter/packages that referenced this pull request Jul 27, 2023
Manual roll requested by [email protected]

flutter/flutter@bae1ac2...61fd11d

2023-07-26 [email protected] Add the 'a:
desktop' label to labeler.yml (flutter/flutter#130933)
2023-07-26 [email protected] ImageDecoration.lerp (#130533)
(flutter/flutter#131349)
2023-07-26 [email protected] Minor adjustments on 2D APIs
(flutter/flutter#131358)
2023-07-26 [email protected] Revert "Update
Unit Tests for M2/M3" (flutter/flutter#131368)
2023-07-26 [email protected] Update Unit
Tests for M2/M3 (flutter/flutter#131292)
2023-07-26 [email protected] Revert "Run
benchmarks with `--omit-type-checks`" (flutter/flutter#131353)
2023-07-26 [email protected] Revert "ImageDecoration.lerp"
(flutter/flutter#131347)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
[email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
QuncCccccc added a commit that referenced this pull request Jul 28, 2023
QuncCccccc added a commit that referenced this pull request Jul 31, 2023
Reverts #131368
Original PR: #131292 . The
flutter mirror was out of date and tree was closed, so the original PR
was reverted. Now should be safe to have a reland.
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
Reverts flutter#131292

This PR is affected by https://g-issues.skia.org/issues/40045533.

See @Piinks's [explanation](https://discord.com/channels/608014603317936148/613398423093116959/1133885989358678076):

> The mirror is probably out of sync. The failing commit introduced new changes, but they have not been updated yet. I would revert the PR until we can check the mirror. Last week it went 2+ hours out of sync so rerunning it may not green the tree for a while.
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
Reverts flutter#131368
Original PR: flutter#131292 . The
flutter mirror was out of date and tree was closed, so the original PR
was reverted. Now should be safe to have a reland.
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
Reverts flutter#131292

This PR is affected by https://g-issues.skia.org/issues/40045533.

See @Piinks's [explanation](https://discord.com/channels/608014603317936148/613398423093116959/1133885989358678076):

> The mirror is probably out of sync. The failing commit introduced new changes, but they have not been updated yet. I would revert the PR until we can check the mirror. Last week it went 2+ hours out of sync so rerunning it may not green the tree for a while.
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
Reverts flutter#131368
Original PR: flutter#131292 . The
flutter mirror was out of date and tree was closed, so the original PR
was reverted. Now should be safe to have a reland.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. revert Autorevert PR (with "Reason for revert:" comment)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants