Skip to content

Conversation

@keyonghan
Copy link
Contributor

This PR add instructions to separate DeviceLab tasks to build and test model.

@keyonghan keyonghan requested a review from CaseyHillers July 26, 2023 22:35
Copy link
Contributor

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter-lgtm

LGTM! I only have some small comments


To better utilize limited DeviceLab testbed resources and speed up overal validation
time, it is now supported to separate building artifacts (.apk/.app) from testing them.
The artifact will be built on a host only bot no needing a device, and the test will run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The artifact will be built on a host only bot no needing a device, and the test will run
The artifact will be built on a host only bot, a VM without a device, and the test will run

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with , a VM or physical bot without. For Linux it is a vm, but for Mac it is a physical bot.

@keyonghan keyonghan added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 27, 2023
@auto-submit auto-submit bot merged commit cfafb91 into flutter:master Jul 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 27, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 27, 2023
flutter/flutter@61fd11d...dd9764e

2023-07-27 [email protected] Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog. (flutter/flutter#131306)
2023-07-27 [email protected] Fix ios_add2app Podfile (flutter/flutter#131263)
2023-07-27 [email protected] Add DeviceLab build+test separation doc (flutter/flutter#131365)
2023-07-27 [email protected] IgnoreBaseline widget (flutter/flutter#131220)
2023-07-27 [email protected] Add 'vm:keep-name' pragmas to platform channel classes (flutter/flutter#131271)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
This PR add instructions to separate DeviceLab tasks to build and test model.
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
This PR add instructions to separate DeviceLab tasks to build and test model.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants