Skip to content

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Jul 26, 2023

Updated unit tests for CheckboxListTile and CalendarDatePicker to have M2 and M3 versions.

More info in #127064

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 26, 2023
@QuncCccccc QuncCccccc changed the title Update CheckboxListTile tests for M2/M3 Update CheckboxListTile and CalendarDatePicker tests for M2/M3 Jul 26, 2023
@QuncCccccc QuncCccccc marked this pull request as ready for review July 27, 2023 02:13
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuncCccccc QuncCccccc force-pushed the update_checkbox_list_tile_test branch from 6b8298f to e06ad07 Compare July 27, 2023 17:03
@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 27, 2023
@QuncCccccc QuncCccccc force-pushed the update_checkbox_list_tile_test branch from e06ad07 to 27517be Compare July 28, 2023 20:04
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 28, 2023

auto label is removed for flutter/flutter, pr: 131363, due to - The status or check suite Mac framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2023
@QuncCccccc QuncCccccc force-pushed the update_checkbox_list_tile_test branch from 27517be to 8a73927 Compare July 31, 2023 17:13
@QuncCccccc QuncCccccc merged commit 3cf206b into flutter:master Jul 31, 2023
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 1, 2023
Manual roll requested by [email protected]

flutter/flutter@1d44fbd...1d59196

2023-07-31 [email protected] Appended period remove & Uri parsing fix. (flutter/flutter#131293)
2023-07-31 [email protected] Fixed regex to show missing assets file error (flutter/flutter#131160)
2023-07-31 [email protected] Update `CheckboxListTile` and `CalendarDatePicker` tests for M2/M3 (flutter/flutter#131363)
2023-07-31 [email protected] Reland --omit-type-checks for benchmarks. (flutter/flutter#131493)
2023-07-31 [email protected] Update the cirrus key jul-31-2023 (flutter/flutter#131624)
2023-07-31 [email protected] Add Expanded/Collapsed State for Semantics (flutter/flutter#131233)
2023-07-31 [email protected] Reland - "Update Unit Tests for M2/M3" (flutter/flutter#131504)
2023-07-31 [email protected] Roll Flutter Engine from ae6d1d60df95 to b83172a4e995 (4 revisions) (flutter/flutter#131614)
2023-07-31 [email protected] Upgrade compile and target sdk versions in tests and benchmarks (flutter/flutter#131428)
2023-07-31 [email protected] Roll Flutter Engine from b11a832ea7d4 to ae6d1d60df95 (1 revision) (flutter/flutter#131611)
2023-07-31 [email protected] Roll Packages from 10aab44 to 60e9a54 (6 revisions) (flutter/flutter#131607)
2023-07-31 [email protected] Fix dartdoc for `ButtonSegment` constructor (flutter/flutter#131400)
2023-07-31 [email protected] [flutter_tools/dap] Improve rendering of structured errors via DAP (flutter/flutter#131251)
2023-07-31 [email protected] [doc] Fix module_test_ios comments (flutter/flutter#131470)
2023-07-31 [email protected] Use Flutter app project's NDK version from FFI plugin (flutter/flutter#131141)
2023-07-31 [email protected] Roll Flutter Engine from 22f9aad5aba5 to b11a832ea7d4 (2 revisions) (flutter/flutter#131597)
2023-07-31 [email protected] Roll Flutter Engine from b84c93601684 to 22f9aad5aba5 (3 revisions) (flutter/flutter#131592)
2023-07-31 [email protected] Roll Flutter Engine from d95adb9c8bc6 to b84c93601684 (1 revision) (flutter/flutter#131585)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants