Preliminary PR for engine changes for Expanded/Collapsed Submenu button #131359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
8 tasks
chunhtai
reviewed
Jul 27, 2023
Contributor
There was a problem hiding this comment.
I vaguely remember there is another test in custom painter you need to disable. Also, I don't think you should put a [intended] here. Unless I have outdated memory, the intended should only be used when it is permanent. For example, a test that only target web platform or etc
Contributor
Author
There was a problem hiding this comment.
Ah I see! Will update the comment and skip the test in custom_painter_test.dart. Thanks a lot!
QuncCccccc
force-pushed
the
skip_tests_for_engine_changes
branch
from
34daf32 to
15077d0
Compare
This was referenced Jul 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 28, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 28, 2023
flutter/flutter@dd9764e...e81907e 2023-07-28 [email protected] Update Chrome to 115, and remove `bringup: true` from skwasm benchmarks. (flutter/flutter#131430) 2023-07-28 [email protected] Fix `TimePicker` defaults for `hourMinuteTextStyle` and `dayPeriodTextColor` for Material 3 (flutter/flutter#131253) 2023-07-28 [email protected] Roll Flutter Engine from cfa5427dc452 to e97014c71014 (3 revisions) (flutter/flutter#131477) 2023-07-28 [email protected] Roll Flutter Engine from dc8618da9eb0 to cfa5427dc452 (3 revisions) (flutter/flutter#131464) 2023-07-28 [email protected] Roll Flutter Engine from b0d97ba45f46 to dc8618da9eb0 (3 revisions) (flutter/flutter#131460) 2023-07-28 [email protected] Updated integration_tests/platform_interaction test_step.dart (flutter/flutter#131301) 2023-07-28 [email protected] Roll Flutter Engine from 0713d91c2e64 to b0d97ba45f46 (1 revision) (flutter/flutter#131453) 2023-07-28 [email protected] Roll Flutter Engine from 01bb0a3ef922 to 0713d91c2e64 (2 revisions) (flutter/flutter#131451) 2023-07-28 [email protected] Roll Flutter Engine from 196474bd96b0 to 01bb0a3ef922 (3 revisions) (flutter/flutter#131447) 2023-07-27 [email protected] Roll Flutter Engine from 284771da323c to 196474bd96b0 (3 revisions) (flutter/flutter#131443) 2023-07-27 [email protected] [framework] clean up image provider documentation. (flutter/flutter#131416) 2023-07-27 [email protected] Fix template app documentation (flutter/flutter#131125) 2023-07-27 [email protected] Roll Flutter Engine from 9a935ecbf73a to 284771da323c (3 revisions) (flutter/flutter#131439) 2023-07-27 [email protected] �� Add `ssh://[email protected]/flutter/flutter.git` as a standard remote (flutter/flutter#131333) 2023-07-27 [email protected] Roll Flutter Engine from f3317dbab388 to 9a935ecbf73a (1 revision) (flutter/flutter#131437) 2023-07-27 [email protected] � Only format Dart files for `gen-l10n` (flutter/flutter#131232) 2023-07-27 [email protected] Roll Flutter Engine from 08050cdecf94 to f3317dbab388 (1 revision) (flutter/flutter#131432) 2023-07-27 [email protected] Preliminary PR for engine changes for Expanded/Collapsed Submenu button (flutter/flutter#131359) 2023-07-27 [email protected] Roll Flutter Engine from 9b14c382eebf to 08050cdecf94 (22 revisions) (flutter/flutter#131426) 2023-07-27 [email protected] Roll Packages from a99fc87 to f4ae933 (3 revisions) (flutter/flutter#131422) 2023-07-27 [email protected] Manual roll to engine commit 9b14c382 using Dart SDK version 3.2.x (flutter/flutter#131371) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…on (flutter#131359) This PR is to skip some unit tests in order to merging an [engine change](flutter/engine#43983).
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
…on (flutter#131359) This PR is to skip some unit tests in order to merging an [engine change](flutter/engine#43983).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to skip some unit tests in order to merging an engine change.
Related to #127617
Pre-launch Checklist
///).