Minor adjustments on 2D APIs #131358
Merged
Minor adjustments on 2D APIs #131358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
added
framework
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 27, 2023
tarrinneal
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 27, 2023
Manual roll requested by [email protected] flutter/flutter@bae1ac2...61fd11d 2023-07-26 [email protected] Add the 'a: desktop' label to labeler.yml (flutter/flutter#130933) 2023-07-26 [email protected] ImageDecoration.lerp (#130533) (flutter/flutter#131349) 2023-07-26 [email protected] Minor adjustments on 2D APIs (flutter/flutter#131358) 2023-07-26 [email protected] Revert "Update Unit Tests for M2/M3" (flutter/flutter#131368) 2023-07-26 [email protected] Update Unit Tests for M2/M3 (flutter/flutter#131292) 2023-07-26 [email protected] Revert "Run benchmarks with `--omit-type-checks`" (flutter/flutter#131353) 2023-07-26 [email protected] Revert "ImageDecoration.lerp" (flutter/flutter#131347) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Piinks
added a commit
to Piinks/flutter
that referenced
this pull request
Jul 27, 2023
These tweaks came from flutter/packages#4536 - The TwoDimensionalChildBuilderDelegate asserts that maxXIndex and maxYIndex are null or >= 0 - The TwoDimensionalChildDelegate setter in RenderTwoDimensionalViewport has a covariant to allow type safety for subclasses of RenderTwoDimensionalViewport implementing with other subclasses of TwoDimensionalChildDelegate I'd like to cherry pick this so flutter/packages#4536 will not have to wait for it to reach stable.
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
These tweaks came from flutter/packages#4536 - The TwoDimensionalChildBuilderDelegate asserts that maxXIndex and maxYIndex are null or >= 0 - The TwoDimensionalChildDelegate setter in RenderTwoDimensionalViewport has a covariant to allow type safety for subclasses of RenderTwoDimensionalViewport implementing with other subclasses of TwoDimensionalChildDelegate I'd like to cherry pick this so flutter/packages#4536 will not have to wait for it to reach stable.
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
These tweaks came from flutter/packages#4536 - The TwoDimensionalChildBuilderDelegate asserts that maxXIndex and maxYIndex are null or >= 0 - The TwoDimensionalChildDelegate setter in RenderTwoDimensionalViewport has a covariant to allow type safety for subclasses of RenderTwoDimensionalViewport implementing with other subclasses of TwoDimensionalChildDelegate I'd like to cherry pick this so flutter/packages#4536 will not have to wait for it to reach stable.
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
These tweaks came from flutter/packages#4536 - The TwoDimensionalChildBuilderDelegate asserts that maxXIndex and maxYIndex are null or >= 0 - The TwoDimensionalChildDelegate setter in RenderTwoDimensionalViewport has a covariant to allow type safety for subclasses of RenderTwoDimensionalViewport implementing with other subclasses of TwoDimensionalChildDelegate I'd like to cherry pick this so flutter/packages#4536 will not have to wait for it to reach stable.
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
While working in https://pub.dev/packages/two_dimensional_scrollables, I found I could eliminate some casts if we added covariants here in the framework. Much of the 2D aPI in the framework is abstract, so I think it make sense to add these and make it easier/cleaner for subclasses using the APIs. I made a similar change in #131358, this would cover all of the cases I could find so its nice and accommodating now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tweaks came from flutter/packages#4536
I'd like to cherry pick this so flutter/packages#4536 will not have to wait for it to reach stable.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.