Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog. #131306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d showAboutDialog. (#130484) ### Overview Add `barrierDismissible`, `barrierColor` and `barrierLabel` parameters to `showDatePicker`, `showTimePicker` and `showAboutDialog` which calls `showDialog` internally. We can change these parameters with `showDialog` and Dialog widgets (like `DatePickerDialog`, `TimePickerDialog` or `AboutDialog`) directly. But, I think it is prefer to provide interfaces same as `showDialog` to keep application wide unified looks if it is used internally. Fixes #130971 (cherry picked from commit 9def8f6)
github-actions
bot
added
framework
Contributor
Author
|
I pulled latest master changes and cherry-picked 9def8f6. Any idea about it? |
Contributor
Author
|
I didn't face the error on my local environment but the test failed as mentioned on CI. I fixed with not to use setupAll to init |
justinmc
approved these changes
Jul 26, 2023
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍 . Thanks for following up on this after it was reverted!
Contributor
|
I would guess that the CI environment is running the tests in parallel, or in a different order, or something like that... Not sure though. |
Contributor
Author
justinmc
approved these changes
Jul 27, 2023
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍. Thanks for changing it to setUp. I guess the name setUpAll is confusing now that I think about it...
There was one test failing but I think it was an infrastructure flake, I've rerun it.
Contributor
|
@HansMuller for secondary review since you already reviewed the original PR #130484. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 27, 2023
…icker and showAboutDialog. (flutter/flutter#131306)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 27, 2023
flutter/flutter@61fd11d...dd9764e 2023-07-27 [email protected] Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog. (flutter/flutter#131306) 2023-07-27 [email protected] Fix ios_add2app Podfile (flutter/flutter#131263) 2023-07-27 [email protected] Add DeviceLab build+test separation doc (flutter/flutter#131365) 2023-07-27 [email protected] IgnoreBaseline widget (flutter/flutter#131220) 2023-07-27 [email protected] Add 'vm:keep-name' pragmas to platform channel classes (flutter/flutter#131271) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…d showAboutDialog. (flutter#131306) Can configure modal barriers in Flutter's built-in dialogs.
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
…d showAboutDialog. (flutter#131306) Can configure modal barriers in Flutter's built-in dialogs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add
barrierDismissible,barrierColorandbarrierLabelparameters toshowDatePicker,showTimePickerandshowAboutDialogwhich callsshowDialoginternally. We can change these parameters withshowDialogand Dialog widgets (likeDatePickerDialog,TimePickerDialogorAboutDialog) directly. But, I think it is prefer to provide interfaces same asshowDialogto keep application wide unified looks if it is used internally.Fixes #130971
(cherry picked from commit 9def8f6)
Context
#130484 was reverted as it caused postsubmit test failures.
I pulled latest master changes and cherry-picked 9def8f6.
Pre-launch Checklist
///).