Appended period remove & Uri parsing fix. #131293

SumitBikram · 2023-07-25T20:31:54Z

Fixed code for the Uri as it includes the period at the end as the part of Uri parsing previously.

As for example:

A crash report has been written to /Users/andrewkolos/Desktop/asset_transformers_test/flutter_03.log.

Many terminals are unable to follow the link because it includes the period in the end as part of it. This PR simply removes the period in the end so that it is clickable in many systems (e.g. by alt -clicking on it in an embedded bash terminal, VSCode).

A crash report has been written to /Users/andrewkolos/Desktop/asset_transformers_test/flutter_03.log

Fixes: #131166

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Fixed code for the Uri as it includes the period at the end as the part of Uri parsing previously.

flutter-dashboard · 2023-07-25T20:31:56Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

google-cla · 2023-07-25T20:31:58Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

thisisjaymehta · 2023-07-26T06:33:12Z

Following test needs to be updated:

https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/general.shard/crash_reporting_test.dart#L103

Fixed the code in crash_reporting_test.dart file.

andrewkolos

LGTM. I validated this locally as well. Thanks for your contribution!

packages/flutter_tools/test/general.shard/crash_reporting_test.dart

This reverts commit b2badd8.

This reverts commit 390e8be.

SumitBikram

Kept it as the requirement!

christopherfujino · 2023-07-27T21:26:40Z

@SumitBikram here is the exact test failure:

01:22 +2735 ~2 -1: test/general.shard/crash_reporting_test.dart: CrashReporter.informUser provides basic instructions without PII [E]                                                                  
  Expected: contains 'A crash report has been written to flutter_00.log.'
    Actual: 'A crash report has been written to flutter_00.log\n'
              ''
     Which: does not contain 'A crash report has been written to flutter_00.log.'
  
  package:matcher                                     expect
  test/general.shard/crash_reporting_test.dart 103:5  main.<fn>

What I would recommend is, rather than using the contains() matcher, trim the string and do an exact string match. Something like this:

    expect(logger.errorText.trim(), 'A crash report has been written to ${file.path}');

Made exact string match with the logger errorText.

Removed the unnecessary change for the period!

This reverts commit b377d80.

Removed the unnecessary change!

andrewkolos · 2023-07-31T04:29:10Z

Looks like one more test needs to be updated in:

flutter/packages/flutter_tools/test/general.shard/crash_reporting_test.dart

Line 103 in cab4609

    
           expect(logger.errorText.trim(), 'A crash report has been written to ${file.path}.');

I think this should be the last that needs to be updated. However, if you still see a failing check after addressing this, you can view the logs by following the "Details" link, following the "View more details on flutter-dashboard" link, and then the "test_stdout" link. You should then see the output. Here is an example.

SumitBikram · 2023-07-31T14:52:56Z

😅Huh! All passed! Is anything left from my end? I think, review is the only thing pending!
@christopherfujino can you please pass the review?

christopherfujino

LGTM. Thanks for this fix!

Fixed code for the Uri as it includes the period at the end as the part of Uri parsing previously. As for example: ``` A crash report has been written to /Users/andrewkolos/Desktop/asset_transformers_test/flutter_03.log. ``` Many terminals are unable to follow the link because it includes the period in the end as part of it. This PR simply removes the period in the end so that it is clickable in many systems (e.g. by `alt` -clicking on it in an embedded bash terminal, VSCode). ``` A crash report has been written to /Users/andrewkolos/Desktop/asset_transformers_test/flutter_03.log ``` Fixes: flutter#131166

…1293)

Manual roll requested by [email protected] flutter/flutter@1d44fbd...1d59196 2023-07-31 [email protected] Appended period remove & Uri parsing fix. (flutter/flutter#131293) 2023-07-31 [email protected] Fixed regex to show missing assets file error (flutter/flutter#131160) 2023-07-31 [email protected] Update `CheckboxListTile` and `CalendarDatePicker` tests for M2/M3 (flutter/flutter#131363) 2023-07-31 [email protected] Reland --omit-type-checks for benchmarks. (flutter/flutter#131493) 2023-07-31 [email protected] Update the cirrus key jul-31-2023 (flutter/flutter#131624) 2023-07-31 [email protected] Add Expanded/Collapsed State for Semantics (flutter/flutter#131233) 2023-07-31 [email protected] Reland - "Update Unit Tests for M2/M3" (flutter/flutter#131504) 2023-07-31 [email protected] Roll Flutter Engine from ae6d1d60df95 to b83172a4e995 (4 revisions) (flutter/flutter#131614) 2023-07-31 [email protected] Upgrade compile and target sdk versions in tests and benchmarks (flutter/flutter#131428) 2023-07-31 [email protected] Roll Flutter Engine from b11a832ea7d4 to ae6d1d60df95 (1 revision) (flutter/flutter#131611) 2023-07-31 [email protected] Roll Packages from 10aab44 to 60e9a54 (6 revisions) (flutter/flutter#131607) 2023-07-31 [email protected] Fix dartdoc for `ButtonSegment` constructor (flutter/flutter#131400) 2023-07-31 [email protected] [flutter_tools/dap] Improve rendering of structured errors via DAP (flutter/flutter#131251) 2023-07-31 [email protected] [doc] Fix module_test_ios comments (flutter/flutter#131470) 2023-07-31 [email protected] Use Flutter app project's NDK version from FFI plugin (flutter/flutter#131141) 2023-07-31 [email protected] Roll Flutter Engine from 22f9aad5aba5 to b11a832ea7d4 (2 revisions) (flutter/flutter#131597) 2023-07-31 [email protected] Roll Flutter Engine from b84c93601684 to 22f9aad5aba5 (3 revisions) (flutter/flutter#131592) 2023-07-31 [email protected] Roll Flutter Engine from d95adb9c8bc6 to b84c93601684 (1 revision) (flutter/flutter#131585) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fixed code for the Uri as it includes the period at the end as the part of Uri parsing previously. As for example: ``` A crash report has been written to /Users/andrewkolos/Desktop/asset_transformers_test/flutter_03.log. ``` Many terminals are unable to follow the link because it includes the period in the end as part of it. This PR simply removes the period in the end so that it is clickable in many systems (e.g. by `alt` -clicking on it in an embedded bash terminal, VSCode). ``` A crash report has been written to /Users/andrewkolos/Desktop/asset_transformers_test/flutter_03.log ``` Fixes: flutter#131166

Update crash_reporting.dart

dbd8558

Fixed code for the Uri as it includes the period at the end as the part of Uri parsing previously.

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 25, 2023

Update crash_reporting_test.dart

b2badd8

Fixed the code in crash_reporting_test.dart file.

andrewkolos self-requested a review July 26, 2023 16:33

andrewkolos approved these changes Jul 26, 2023

View reviewed changes

andrewkolos requested a review from christopherfujino July 26, 2023 16:40

christopherfujino suggested changes Jul 26, 2023

View reviewed changes

packages/flutter_tools/test/general.shard/crash_reporting_test.dart Outdated Show resolved Hide resolved

SumitBikram added 3 commits July 26, 2023 23:35

Revert "Update crash_reporting_test.dart"

390e8be

This reverts commit b2badd8.

Revert "Revert "Update crash_reporting_test.dart""

dfedd25

This reverts commit 390e8be.

Update crash_reporting_test.dart

b2e0211

SumitBikram commented Jul 26, 2023

View reviewed changes

SumitBikram added 2 commits July 28, 2023 11:11

Update crash_reporting_test

4499760

Made exact string match with the logger errorText.

Merge branch 'flutter:master' into master

4742dca

SumitBikram requested a review from christopherfujino July 28, 2023 06:49

SumitBikram added 4 commits July 28, 2023 12:28

Update crash_reporting_test

b377d80

Removed the unnecessary change for the period!

Revert "Update crash_reporting_test"

671a7a0

This reverts commit b377d80.

Merge branch 'flutter:master' into master

29e7958

Update crash_reporting_test

cab4609

Removed the unnecessary change!

SumitBikram added 2 commits July 31, 2023 18:35

Appended Period Remove!

2452ae4

Merge branch 'master' into master

8aa2a3e

christopherfujino approved these changes Jul 31, 2023

View reviewed changes

christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2023

auto-submit bot merged commit 1d59196 into flutter:master Jul 31, 2023

engine-flutter-autoroll mentioned this pull request Jul 31, 2023

Manual roll Flutter from 1d44fbd8b906 to 1d59196bafdb (18 revisions) flutter/packages#4621

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2023

1d59196 Appended period remove & Uri parsing fix. (flutter/flutter#13…

01d020d

…1293)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Appended period remove & Uri parsing fix. #131293

Appended period remove & Uri parsing fix. #131293

Uh oh!

SumitBikram commented Jul 25, 2023 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Jul 25, 2023

Uh oh!

google-cla bot commented Jul 25, 2023

Uh oh!

thisisjaymehta commented Jul 26, 2023

Uh oh!

andrewkolos left a comment •

edited

Loading

Uh oh!

Uh oh!

SumitBikram left a comment

Uh oh!

christopherfujino commented Jul 27, 2023

Uh oh!

andrewkolos commented Jul 31, 2023

Uh oh!

SumitBikram commented Jul 31, 2023 •

edited

Loading

Uh oh!

christopherfujino left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Appended period remove & Uri parsing fix. #131293

Appended period remove & Uri parsing fix. #131293

Uh oh!

Conversation

SumitBikram commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Jul 25, 2023

Uh oh!

google-cla bot commented Jul 25, 2023

Uh oh!

thisisjaymehta commented Jul 26, 2023

Uh oh!

andrewkolos left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SumitBikram left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino commented Jul 27, 2023

Uh oh!

andrewkolos commented Jul 31, 2023

Uh oh!

SumitBikram commented Jul 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SumitBikram commented Jul 25, 2023 •

edited

Loading

andrewkolos left a comment •

edited

Loading

SumitBikram commented Jul 31, 2023 •

edited

Loading