Update Unit Tests for M2/M3 #131292
Merged
Update Unit Tests for M2/M3 #131292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
HansMuller
approved these changes
Jul 26, 2023
Contributor
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
LGTM
Looks like you need to approve some golden images.
TahaTesser
requested changes
Jul 26, 2023
Contributor
Author
Will triage them! Thanks:) |
|
Golden file changes are available for triage from new commit, Click here to view. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
QuncCccccc
added
the
autosubmit
loic-sharma
added a commit
that referenced
this pull request
Jul 26, 2023
This reverts commit 5d76d1a.
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
Reverts #131292 This PR is affected by https://g-issues.skia.org/issues/40045533. See @Piinks's [explanation](https://discord.com/channels/608014603317936148/613398423093116959/1133885989358678076): > The mirror is probably out of sync. The failing commit introduced new changes, but they have not been updated yet. I would revert the PR until we can check the mirror. Last week it went 2+ hours out of sync so rerunning it may not green the tree for a while.
Member
|
@QuncCccccc This PR had to be reverted as it was affected by this Flutter Gold issue: https://g-issues.skia.org/issues/40045533. See @Piinks's explanation:
|
QuncCccccc
added a commit
that referenced
this pull request
Jul 26, 2023
This reverts commit 5d76d1a.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 27, 2023
tarrinneal
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 27, 2023
Manual roll requested by [email protected] flutter/flutter@bae1ac2...61fd11d 2023-07-26 [email protected] Add the 'a: desktop' label to labeler.yml (flutter/flutter#130933) 2023-07-26 [email protected] ImageDecoration.lerp (#130533) (flutter/flutter#131349) 2023-07-26 [email protected] Minor adjustments on 2D APIs (flutter/flutter#131358) 2023-07-26 [email protected] Revert "Update Unit Tests for M2/M3" (flutter/flutter#131368) 2023-07-26 [email protected] Update Unit Tests for M2/M3 (flutter/flutter#131292) 2023-07-26 [email protected] Revert "Run benchmarks with `--omit-type-checks`" (flutter/flutter#131353) 2023-07-26 [email protected] Revert "ImageDecoration.lerp" (flutter/flutter#131347) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
QuncCccccc
added a commit
that referenced
this pull request
Jul 31, 2023
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
Updated golden tests in * ink_sparkle_test.dart * material_test.dart * page_test.dart * progress_indicator_test.dart to have M2 and M3 versions. More info in flutter#127064
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
Reverts flutter#131292 This PR is affected by https://g-issues.skia.org/issues/40045533. See @Piinks's [explanation](https://discord.com/channels/608014603317936148/613398423093116959/1133885989358678076): > The mirror is probably out of sync. The failing commit introduced new changes, but they have not been updated yet. I would revert the PR until we can check the mirror. Last week it went 2+ hours out of sync so rerunning it may not green the tree for a while.
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
Reverts flutter#131368 Original PR: flutter#131292 . The flutter mirror was out of date and tree was closed, so the original PR was reverted. Now should be safe to have a reland.
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
Updated golden tests in * ink_sparkle_test.dart * material_test.dart * page_test.dart * progress_indicator_test.dart to have M2 and M3 versions. More info in flutter#127064
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
Reverts flutter#131292 This PR is affected by https://g-issues.skia.org/issues/40045533. See @Piinks's [explanation](https://discord.com/channels/608014603317936148/613398423093116959/1133885989358678076): > The mirror is probably out of sync. The failing commit introduced new changes, but they have not been updated yet. I would revert the PR until we can check the mirror. Last week it went 2+ hours out of sync so rerunning it may not green the tree for a while.
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
Reverts flutter#131368 Original PR: flutter#131292 . The flutter mirror was out of date and tree was closed, so the original PR was reverted. Now should be safe to have a reland.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated golden tests in
to have M2 and M3 versions.
More info in #127064
Pre-launch Checklist
///).