Add 'vm:keep-name' pragmas to platform channel classes #131271
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
the
framework
|
test-exempt: configuration change bonus points if someone wants to write a test that verifies that these names don't get mangled by the obfuscator, just to increase our confidence, but that shouldn't block the PR from landing. Looks like some of the tests failed but the failures don't seem related to the PR. We'll rerun them shortly to check. |
goderbauer
force-pushed
the
method-channel-pragma
branch
from
f9a6cc7 to
be130ea
Compare
goderbauer
added
the
autosubmit
|
auto label is removed for flutter/flutter, pr: 131271, due to - The status or check suite Linux_android android_defines_test has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
AlexV525
added
the
autosubmit
flutter/flutter@61fd11d...dd9764e 2023-07-27 [email protected] Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog. (flutter/flutter#131306) 2023-07-27 [email protected] Fix ios_add2app Podfile (flutter/flutter#131263) 2023-07-27 [email protected] Add DeviceLab build+test separation doc (flutter/flutter#131365) 2023-07-27 [email protected] IgnoreBaseline widget (flutter/flutter#131220) 2023-07-27 [email protected] Add 'vm:keep-name' pragmas to platform channel classes (flutter/flutter#131271) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Pragma will allow future proofing Dart snapshot utilities to work by preserving the names of important classes used in platform channel communication @Hixie
Pragma will allow future proofing Dart snapshot utilities to work by preserving the names of important classes used in platform channel communication @Hixie
4 participants
Pragma will allow future proofing Dart snapshot utilities to work by preserving the names of important classes used in platform channel communication
@Hixie