Fix ios_add2app Podfile #131263
Merged
Fix ios_add2app Podfile #131263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@vashworth should we land this PR, or you'd rather only land changes if we actually enable this test again? |
vashworth
requested changes
Jul 26, 2023
Contributor
vashworth
left a comment
vashworth
left a comment
There was a problem hiding this comment.
I think we can land this, but can you remove the changes to the project.pbxproj? I believe part of the test is that it successfully automates updated it
dcharkes
added
the
autosubmit
Contributor
Author
|
Automerge doesn't work if "Google testing" doesn't run the test Manually merging. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 27, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 27, 2023
flutter/flutter@61fd11d...dd9764e 2023-07-27 [email protected] Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog. (flutter/flutter#131306) 2023-07-27 [email protected] Fix ios_add2app Podfile (flutter/flutter#131263) 2023-07-27 [email protected] Add DeviceLab build+test separation doc (flutter/flutter#131365) 2023-07-27 [email protected] IgnoreBaseline widget (flutter/flutter#131220) 2023-07-27 [email protected] Add 'vm:keep-name' pragmas to platform channel classes (flutter/flutter#131271) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: