Skip to content

🐛 Only format Dart files for gen-l10n #131232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Jul 27, 2023
Merged

🐛 Only format Dart files for gen-l10n #131232

auto-submit merged 3 commits into from
Jul 27, 2023

Conversation

@AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Jul 25, 2023 •
edited
Loading

Improves #119596. The tests remain valid, so no tests were updated in the request.

This does not resolve issue #128932, it's handled by another part of the code.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 25, 2023
@AlexV525 AlexV525 marked this pull request as ready for review July 25, 2023 07:10
@thkim1011
Copy link
Contributor

thkim1011 commented Jul 26, 2023

Is it possible to write a test that calls generateLocalizations twice, but with different untranslatedMessageFile names? I think this scenario should cause it to error when using the old behavior. If this doesn't work, we should request a test exemption from Hixie in the #hackers channel of the Flutter Discord.

@AlexV525
Copy link
Member Author

AlexV525 commented Jul 26, 2023

Is it possible to write a test that calls generateLocalizations twice, but with different untranslatedMessageFile names? I think this scenario should cause it to error when using the old behavior.

The untranslated file has been filtered out before, so I think it should not work as intended? (Throws exception)

@Hixie
Copy link
Contributor

Hixie commented Jul 27, 2023

test-exempt: code refactor with no semantic change

@AlexV525
Copy link
Member Author

AlexV525 commented Jul 27, 2023

@thkim1011 PTAL

thkim1011
thkim1011 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@thkim1011 thkim1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thkim1011 thkim1011 added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 27, 2023
@auto-submit auto-submit bot merged commit eab2087 into flutter:master Jul 27, 2023
@AlexV525 AlexV525 deleted the fix/do-not-format-files-other-than-arbs branch July 27, 2023 23:06
This was referenced Jul 28, 2023
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2023
@engine-flutter-autoroll
eab2087 🐛 Only format Dart files for gen-l10n (flutter/flutter#131232)
e58126a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2023
@engine-flutter-autoroll
eab2087 🐛 Only format Dart files for gen-l10n (flutter/flutter#131232)
cecbe33
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 28, 2023
@engine-flutter-autoroll
Roll Flutter from dd9764e to e81907e (21 revisions) (#4582)
441895b 
flutter/flutter@dd9764e...e81907e

2023-07-28 [email protected] Update Chrome to 115, and remove `bringup: true` from skwasm benchmarks. (flutter/flutter#131430)
2023-07-28 [email protected] Fix `TimePicker` defaults for `hourMinuteTextStyle` and `dayPeriodTextColor` for Material 3 (flutter/flutter#131253)
2023-07-28 [email protected] Roll Flutter Engine from cfa5427dc452 to e97014c71014 (3 revisions) (flutter/flutter#131477)
2023-07-28 [email protected] Roll Flutter Engine from dc8618da9eb0 to cfa5427dc452 (3 revisions) (flutter/flutter#131464)
2023-07-28 [email protected] Roll Flutter Engine from b0d97ba45f46 to dc8618da9eb0 (3 revisions) (flutter/flutter#131460)
2023-07-28 [email protected] Updated integration_tests/platform_interaction test_step.dart (flutter/flutter#131301)
2023-07-28 [email protected] Roll Flutter Engine from 0713d91c2e64 to b0d97ba45f46 (1 revision) (flutter/flutter#131453)
2023-07-28 [email protected] Roll Flutter Engine from 01bb0a3ef922 to 0713d91c2e64 (2 revisions) (flutter/flutter#131451)
2023-07-28 [email protected] Roll Flutter Engine from 196474bd96b0 to 01bb0a3ef922 (3 revisions) (flutter/flutter#131447)
2023-07-27 [email protected] Roll Flutter Engine from 284771da323c to 196474bd96b0 (3 revisions) (flutter/flutter#131443)
2023-07-27 [email protected] [framework] clean up image provider documentation. (flutter/flutter#131416)
2023-07-27 [email protected] Fix template app documentation (flutter/flutter#131125)
2023-07-27 [email protected] Roll Flutter Engine from 9a935ecbf73a to 284771da323c (3 revisions) (flutter/flutter#131439)
2023-07-27 [email protected] â�¡ï¸� Add `ssh://[email protected]/flutter/flutter.git` as a standard remote (flutter/flutter#131333)
2023-07-27 [email protected] Roll Flutter Engine from f3317dbab388 to 9a935ecbf73a (1 revision) (flutter/flutter#131437)
2023-07-27 [email protected] ð��� Only format Dart files for `gen-l10n` (flutter/flutter#131232)
2023-07-27 [email protected] Roll Flutter Engine from 08050cdecf94 to f3317dbab388 (1 revision) (flutter/flutter#131432)
2023-07-27 [email protected] Preliminary PR for engine changes for Expanded/Collapsed Submenu button (flutter/flutter#131359)
2023-07-27 [email protected] Roll Flutter Engine from 9b14c382eebf to 08050cdecf94 (22 revisions) (flutter/flutter#131426)
2023-07-27 [email protected] Roll Packages from a99fc87 to f4ae933 (3 revisions) (flutter/flutter#131422)
2023-07-27 [email protected] Manual roll to engine commit 9b14c382 using Dart SDK version 3.2.x (flutter/flutter#131371)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@AlexV525 @LouiseHsu
🐛 Only format Dart files for gen-l10n (flutter#131232)
c403f50 
Improves flutter#119596. The tests remain valid, so no tests were updated in the request.

This does not resolve issue flutter#128932, it's handled by another part of the code.
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
@AlexV525 @vashworth
🐛 Only format Dart files for gen-l10n (flutter#131232)
a2bbf21 
Improves flutter#119596. The tests remain valid, so no tests were updated in the request.

This does not resolve issue flutter#128932, it's handled by another part of the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thkim1011 thkim1011 thkim1011 approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexV525 @thkim1011 @Hixie