Use Flutter app project's NDK version from FFI plugin #131141

temeddix · 2023-07-23T03:43:13Z

In most cases, a FFI plugin doesn't need its own specific Android NDK version. Just following the Flutter app project's NDK version is enough.

If a Flutter app project depends on multiple FFI plugins that use different Android NDK versions, it can be quite wasteful and use excessive disk space due to multiple NDK installations.

Using Flutter app project's NDK version is also less error-prone because upgrading the Flutter SDK would be enough when upgrading FFI plugins(If project's ndkVersion is flutter.ndkVersion), without messing with Android NDK installations.

This problem was discussed in some actual FFI plugin repositories, and they are striving to find their own solutions:

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2023-07-23T03:43:15Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Hixie · 2023-07-23T07:15:37Z

test-exempt: configuration change

christopherfujino · 2023-07-27T21:03:47Z

@dcharkes is this a safe change to make?

dcharkes · 2023-07-28T08:46:43Z

Here is all the discussion on it when landing support for FFI plugins: NDK versioning doc.

Reading the doc and comments, we went for specifying the value in the plugin so that the plugins specify a lower bound and added logic to check that the app NDK version as at least as new as the plugins. If plugin authors still need a lower bound they can follow the comment that is added to the template.

In most cases, a FFI plugin doesn't need its own specific Android NDK version.

In the mentioned doc we note the same.

I believe this change to be safe. (Plugin authors who do need an NDK lower bound, need to read that comment and manually put in an NDK version, or their example app will immediately fail if it lists a too low NDK version.)

auto-submit · 2023-07-28T09:20:23Z

auto label is removed for flutter/flutter, pr: 131141, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

christopherfujino · 2023-07-28T18:33:28Z

Here is all the discussion on it when landing support for FFI plugins: NDK versioning doc.

Reading the doc and comments, we went for specifying the value in the plugin so that the plugins specify a lower bound and added logic to check that the app NDK version as at least as new as the plugins. If plugin authors still need a lower bound they can follow the comment that is added to the template.

In most cases, a FFI plugin doesn't need its own specific Android NDK version.

In the mentioned doc we note the same.

I believe this change to be safe. (Plugin authors who do need an NDK lower bound, need to read that comment and manually put in an NDK version, or their example app will immediately fail if it lists a too low NDK version.)

Thanks

christopherfujino

LGTM

auto-submit · 2023-07-28T18:57:22Z

auto label is removed for flutter/flutter, pr: 131141, due to - The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

temeddix · 2023-07-30T03:38:18Z

@christopherfujino It looks like auto label was remove due to this error #131141 (comment). Would you mind handling this again?

…r/flutter#131141)

<img width="1119" alt="image" src="https://github.com/flutter/flutter/assets/66480156/e2e8eed1-3bef-436c-b21f-3891bdbe05bb"> In most cases, a FFI plugin doesn't need its own specific Android NDK version. Just following the Flutter app project's NDK version is enough. If a Flutter app project depends on multiple FFI plugins that use different Android NDK versions, it can be quite wasteful and use excessive disk space due to multiple NDK installations. Using Flutter app project's NDK version is also less error-prone because upgrading the Flutter SDK would be enough when upgrading FFI plugins(If project's `ndkVersion` is `flutter.ndkVersion`), without messing with Android NDK installations. This problem was discussed in some actual FFI plugin repositories, and they are striving to find their own solutions: - superlistapp/super_native_extensions#143 (comment) - cunarist/rinf#60 (comment) - rive-app/rive-flutter#320 - juicycleff/flutter-unity-view-widget#832

…r/flutter#131141)

Manual roll requested by [email protected] flutter/flutter@1d44fbd...1d59196 2023-07-31 [email protected] Appended period remove & Uri parsing fix. (flutter/flutter#131293) 2023-07-31 [email protected] Fixed regex to show missing assets file error (flutter/flutter#131160) 2023-07-31 [email protected] Update `CheckboxListTile` and `CalendarDatePicker` tests for M2/M3 (flutter/flutter#131363) 2023-07-31 [email protected] Reland --omit-type-checks for benchmarks. (flutter/flutter#131493) 2023-07-31 [email protected] Update the cirrus key jul-31-2023 (flutter/flutter#131624) 2023-07-31 [email protected] Add Expanded/Collapsed State for Semantics (flutter/flutter#131233) 2023-07-31 [email protected] Reland - "Update Unit Tests for M2/M3" (flutter/flutter#131504) 2023-07-31 [email protected] Roll Flutter Engine from ae6d1d60df95 to b83172a4e995 (4 revisions) (flutter/flutter#131614) 2023-07-31 [email protected] Upgrade compile and target sdk versions in tests and benchmarks (flutter/flutter#131428) 2023-07-31 [email protected] Roll Flutter Engine from b11a832ea7d4 to ae6d1d60df95 (1 revision) (flutter/flutter#131611) 2023-07-31 [email protected] Roll Packages from 10aab44 to 60e9a54 (6 revisions) (flutter/flutter#131607) 2023-07-31 [email protected] Fix dartdoc for `ButtonSegment` constructor (flutter/flutter#131400) 2023-07-31 [email protected] [flutter_tools/dap] Improve rendering of structured errors via DAP (flutter/flutter#131251) 2023-07-31 [email protected] [doc] Fix module_test_ios comments (flutter/flutter#131470) 2023-07-31 [email protected] Use Flutter app project's NDK version from FFI plugin (flutter/flutter#131141) 2023-07-31 [email protected] Roll Flutter Engine from 22f9aad5aba5 to b11a832ea7d4 (2 revisions) (flutter/flutter#131597) 2023-07-31 [email protected] Roll Flutter Engine from b84c93601684 to 22f9aad5aba5 (3 revisions) (flutter/flutter#131592) 2023-07-31 [email protected] Roll Flutter Engine from d95adb9c8bc6 to b84c93601684 (1 revision) (flutter/flutter#131585) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

<img width="1119" alt="image" src="https://github.com/flutter/flutter/assets/66480156/e2e8eed1-3bef-436c-b21f-3891bdbe05bb"> In most cases, a FFI plugin doesn't need its own specific Android NDK version. Just following the Flutter app project's NDK version is enough. If a Flutter app project depends on multiple FFI plugins that use different Android NDK versions, it can be quite wasteful and use excessive disk space due to multiple NDK installations. Using Flutter app project's NDK version is also less error-prone because upgrading the Flutter SDK would be enough when upgrading FFI plugins(If project's `ndkVersion` is `flutter.ndkVersion`), without messing with Android NDK installations. This problem was discussed in some actual FFI plugin repositories, and they are striving to find their own solutions: - superlistapp/super_native_extensions#143 (comment) - cunarist/rinf#60 (comment) - rive-app/rive-flutter#320 - juicycleff/flutter-unity-view-widget#832

Use Flutter project's NDK version from FFI plugin

1d357c1

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 23, 2023

Merge branch 'master' into master

efac748

temeddix changed the title ~~Use Flutter project's NDK version from FFI plugin~~ Use Flutter app project's NDK version from FFI plugin Jul 23, 2023

temeddix added 4 commits July 23, 2023 17:41

Also replace android.ndkVersion string in tests

8844486

Merge branch 'master' into master

8470ac9

Merge branch 'flutter:master' into master

7217f44

Merge branch 'master' into master

8b323c0

christopherfujino requested a review from dcharkes July 27, 2023 21:03

dcharkes approved these changes Jul 28, 2023

View reviewed changes

Merge branch 'master' into master

6748455

dcharkes added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2023

dcharkes requested a review from christopherfujino July 28, 2023 09:24

christopherfujino approved these changes Jul 28, 2023

View reviewed changes

christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2023

Merge branch 'master' into master

ecddc35

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2023

temeddix added 3 commits July 29, 2023 04:59

Merge branch 'master' into master

c5ae230

Merge branch 'master' into master

eba9ffd

Merge branch 'master' into master

2c1c15e

dcharkes added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2023

auto-submit bot merged commit c05c3d3 into flutter:master Jul 31, 2023

engine-flutter-autoroll mentioned this pull request Jul 31, 2023

Roll Flutter from 1d44fbd8b906 to 28ee5581784e (7 revisions) flutter/packages#4610

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2023

c05c3d3 Use Flutter app project's NDK version from FFI plugin (flutte…

e9986b8

…r/flutter#131141)

engine-flutter-autoroll mentioned this pull request Jul 31, 2023

Roll Flutter from 1d44fbd8b906 to 0881d07e135d (8 revisions) flutter/packages#4611

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2023

c05c3d3 Use Flutter app project's NDK version from FFI plugin (flutte…

c3710c2

…r/flutter#131141)

engine-flutter-autoroll mentioned this pull request Jul 31, 2023

Roll Flutter from 1d44fbd8b906 to 972d36c4efee (9 revisions) flutter/packages#4612

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2023

c05c3d3 Use Flutter app project's NDK version from FFI plugin (flutte…

5a03796

…r/flutter#131141)

engine-flutter-autoroll mentioned this pull request Jul 31, 2023

Roll Flutter from 1d44fbd8b906 to ae750e57f5e9 (10 revisions) flutter/packages#4615

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2023

c05c3d3 Use Flutter app project's NDK version from FFI plugin (flutte…

5583d84

…r/flutter#131141)

engine-flutter-autoroll mentioned this pull request Jul 31, 2023

Roll Flutter from 1d44fbd8b906 to 544c04089686 (11 revisions) flutter/packages#4617

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2023

c05c3d3 Use Flutter app project's NDK version from FFI plugin (flutte…

6e84009

…r/flutter#131141)

engine-flutter-autoroll mentioned this pull request Jul 31, 2023

Manual roll Flutter from 1d44fbd8b906 to 1d59196bafdb (18 revisions) flutter/packages#4621

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 31, 2023

c05c3d3 Use Flutter app project's NDK version from FFI plugin (flutte…

55406a6

…r/flutter#131141)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use Flutter app project's NDK version from FFI plugin #131141

Use Flutter app project's NDK version from FFI plugin #131141

Uh oh!

temeddix commented Jul 23, 2023 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Jul 23, 2023

Uh oh!

Hixie commented Jul 23, 2023

Uh oh!

christopherfujino commented Jul 27, 2023

Uh oh!

dcharkes commented Jul 28, 2023 •

edited

Loading

Uh oh!

auto-submit bot commented Jul 28, 2023

Uh oh!

christopherfujino commented Jul 28, 2023

Uh oh!

christopherfujino left a comment

Uh oh!

auto-submit bot commented Jul 28, 2023

Uh oh!

temeddix commented Jul 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Use Flutter app project's NDK version from FFI plugin #131141

Use Flutter app project's NDK version from FFI plugin #131141

Uh oh!

Conversation

temeddix commented Jul 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Jul 23, 2023

Uh oh!

Hixie commented Jul 23, 2023

Uh oh!

christopherfujino commented Jul 27, 2023

Uh oh!

dcharkes commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

auto-submit bot commented Jul 28, 2023

Uh oh!

christopherfujino commented Jul 28, 2023

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jul 28, 2023

Uh oh!

temeddix commented Jul 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

temeddix commented Jul 23, 2023 •

edited

Loading

dcharkes commented Jul 28, 2023 •

edited

Loading