Access to fragment in router state on page refresh #131123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
vasilich6107
force-pushed
the
bugfix/access_to_fragment_in_router_state_on_page_refresh
branch
2 times, most recently
from
2a86591 to
e5e3827
Compare
chunhtai
approved these changes
Jul 27, 2023
Contributor
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, but we should have one person from web team to also take a look at this pr
Contributor
Author
|
Hi @mdebbar |
vasilich6107
force-pushed
the
bugfix/access_to_fragment_in_router_state_on_page_refresh
branch
from
e5e3827 to
f29996c
Compare
Contributor
|
The change looks good but I'm concerned that this might break existing applications that rely on a full match on the path, eg: MaterialApp(
initialRoute: '/',
routes: {
'/': (_) => HomePage(),
'/profile': (_) => ProfilePage(),
'/settings': (_) => SettingsPage(),
},
)If someone navigates to In order to avoid the breakage, I suggest one of two options:
class PathAndHashUrlStrategy extends PathUrlStrategy {
final BrowserPlatformLocation _platformLocation = BrowserPlatformLocation();
@override
String getPath() {
return super.getPath() + _platformLocation.hash;
}
}
void main() {
setUrlStrategy(PathAndHashUrlStrategy());
runApp(MyApp());
}
|
Contributor
|
yes this seems like a possible breaking change.
|
Contributor
Author
|
Thanks for feedback |
vasilich6107
force-pushed
the
bugfix/access_to_fragment_in_router_state_on_page_refresh
branch
3 times, most recently
from
83eb873 to
dfe04ea
Compare
vasilich6107
force-pushed
the
bugfix/access_to_fragment_in_router_state_on_page_refresh
branch
from
dfe04ea to
680a013
Compare
Contributor
Author
|
Hi @mdebbar |
mdebbar
approved these changes
Sep 18, 2023
Contributor
mdebbar
left a comment
mdebbar
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for the contribution!
mdebbar
added
the
autosubmit
vasilich6107
deleted the
bugfix/access_to_fragment_in_router_state_on_page_refresh
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 19, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 19, 2023
flutter/flutter@b7d0e8c...8936504 2023-09-19 [email protected] Roll Flutter Engine from e1c784e3f841 to 589bde9a95c9 (16 revisions) (flutter/flutter#134998) 2023-09-19 [email protected] Reland Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134983) 2023-09-18 [email protected] Revert "Resolve breaking change of adding a method to ChangeNotifier." (flutter/flutter#134978) 2023-09-18 [email protected] Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134953) 2023-09-18 [email protected] Fixes focus traversal crash if the current node can't request focus (flutter/flutter#134954) 2023-09-18 [email protected] Access to fragment in router state on page refresh (flutter/flutter#131123) 2023-09-18 [email protected] Enable private field promotion for framework (flutter/flutter#134473) 2023-09-18 [email protected] Cover more test/widgets tests with leak tracking #6 (flutter/flutter#134884) 2023-09-18 [email protected] Cover more tests with leak tracking. (flutter/flutter#134805) 2023-09-18 [email protected] Cover more test/widgets tests with leak tracking #5 (flutter/flutter#134869) 2023-09-18 [email protected] Don't uninstall before retrying to connect during app launch (flutter/flutter#134542) 2023-09-18 [email protected] [flutter roll] Revert "LinkedText (Linkify)" (flutter/flutter#134955) 2023-09-18 [email protected] Fix memory leak in _DarwinViewState. (flutter/flutter#134938) 2023-09-18 [email protected] Roll Flutter Engine from be7a039c5451 to e1c784e3f841 (3 revisions) (flutter/flutter#134956) 2023-09-18 [email protected] Migrate the "Missing frames / speed related performance issues" issue template to use Github forms (flutter/flutter#134033) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
This PR fixes the issue flutter#108614 Particularly this behaviour flutter#108614 (comment) Update editable_text.dart
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #108614
Particularly this behaviour #108614 (comment)
Pre-launch Checklist
///).