Skip to content

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Jul 21, 2023

Part of #133171.

Removes from TestWindow:

  • localeTestValue
  • clearLocaleTestValue
  • localesTestValue
  • clearLocalesTestValue
  • initialLifecycleStateTestValue
  • alwaysUse24HourFormatTestValue
  • clearAlwaysUse24HourTestValue
  • brieflyShowPasswordTestValue
  • defaultRouteNameTestValue
  • clearDefaultRouteNameTestValue
  • semanticsEnabledTestValue
  • clearSemanticsEnabledTestValue
  • accessibilityFeaturesTestValue
  • clearAccessibilityFeaturesTestValue

These properties have reached the end of their deprecation period.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jul 21, 2023
@goderbauer goderbauer closed this Jul 24, 2023
@goderbauer goderbauer changed the title WIP Remove deprecated *TestValues from TestWindow Aug 17, 2023
@goderbauer goderbauer reopened this Aug 17, 2023
@goderbauer goderbauer force-pushed the deprecations branch 2 times, most recently from 5c3ef7b to 22ea1ed Compare August 17, 2023 17:43
@Piinks
Copy link
Contributor

Piinks commented Aug 17, 2023

Woohoo! We haven't announced these yet (usually a week after release), so let's wait to land until it has been announced.

@goderbauer
Copy link
Member Author

Yeah, there's no rush to land this :)

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 23, 2023
@auto-submit auto-submit bot merged commit ad78cf3 into flutter:master Aug 23, 2023
@goderbauer goderbauer deleted the deprecations branch August 23, 2023 20:31
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 24, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 24, 2023
flutter/flutter@bd836cc...deeb811

2023-08-24 [email protected] Reverts "Roll Flutter Engine from aa98a9d2e86f to 3b92bb6eda19 (4 revisions) (#133224)" (flutter/flutter#133255)
2023-08-24 [email protected] Roll Flutter Engine from aa98a9d2e86f to 3b92bb6eda19 (4 revisions) (flutter/flutter#133224)
2023-08-24 [email protected] Roll Flutter Engine from 67e8b825cc91 to aa98a9d2e86f (4 revisions) (flutter/flutter#133220)
2023-08-24 [email protected] Roll Flutter Engine from 27d75f6221d2 to 67e8b825cc91 (1 revision) (flutter/flutter#133214)
2023-08-23 [email protected] Remove deprecated PlatformViewsService.synchronizeToNativeViewHierarchy (flutter/flutter#133175)
2023-08-23 [email protected] Roll Flutter Engine from 58dc868c26cb to 27d75f6221d2 (14 revisions) (flutter/flutter#133211)
2023-08-23 [email protected] Remove deprecated MaterialButtonWithIconMixin (flutter/flutter#133173)
2023-08-23 [email protected] Enable ChangeNotifier clients to dispatch event of object creation in constructor. (flutter/flutter#133060)
2023-08-23 [email protected] Enable literal_only_boolean_expressions (flutter/flutter#133186)
2023-08-23 [email protected] Add android analyzer commands for applinks (flutter/flutter#131009)
2023-08-23 [email protected] Bump memory usage in gradle for platform views (flutter/flutter#133155)
2023-08-23 [email protected] [flutter_tools] Fix legacy version file not being ensured (flutter/flutter#133097)
2023-08-23 [email protected] Remove deprecated *TestValues from TestWindow (flutter/flutter#131098)
2023-08-23 [email protected] Roll Flutter Engine from ac352ba95f43 to 58dc868c26cb (2 revisions) (flutter/flutter#133165)
2023-08-23 [email protected] [web] Remove unnecessary lint ignore (flutter/flutter#133164)
2023-08-23 [email protected] Add `--experimental-wasm-type-reflection` and support newer emscripten builds. (flutter/flutter#133084)
2023-08-23 [email protected] Roll Flutter Engine from 72a06427bd37 to ac352ba95f43 (2 revisions) (flutter/flutter#133158)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants