Remove obsolete work around for shadow drawing #131066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
framework
flar
approved these changes
Jul 21, 2023
Contributor
flar
left a comment
flar
left a comment
There was a problem hiding this comment.
Looks very similar to another that we removed before. There may be scuba diffs with this...
goderbauer
force-pushed
the
removeShadowTodo
branch
from
2bf3ead to
e6b6af2
Compare
goderbauer
added
the
autosubmit
Contributor
|
You can see the history on the prior fix here: #127052 It had to be reverted and relanded due to golden failures. I think in that case we realized that the web needed the workaround and so we had to land a fix to the web before we relanded the fix that removed the workaround from the framework. You might want to check out the tests that failed and make sure the same thing doesn't happen here. @jason-simmons landed the web workaround here: flutter/engine#42304 |
goderbauer
removed
the
autosubmit
Member
Author
|
Kicked off a TGP to see if this breaks anything in g3 (OCL:550046596:BASE:550044778:1689973967576:ba883be0). All open source tests are still passing. |
Member
Author
|
TGP didn't surface any issues. |
goderbauer
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 22, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 22, 2023
flutter/flutter@9cfbf6b...e8b397c 2023-07-22 [email protected] Setup leak tracking regression for material. (flutter/flutter#130169) 2023-07-22 [email protected] Roll Flutter Engine from 6344b17a2e03 to 481684a6e276 (2 revisions) (flutter/flutter#131118) 2023-07-22 [email protected] Roll Flutter Engine from b47cf14fda0e to 6344b17a2e03 (1 revision) (flutter/flutter#131114) 2023-07-22 [email protected] Roll Flutter Engine from 840bcc3449ff to b47cf14fda0e (3 revisions) (flutter/flutter#131109) 2023-07-22 [email protected] Roll Flutter Engine from 2d8cff44261b to 840bcc3449ff (11 revisions) (flutter/flutter#131101) 2023-07-21 [email protected] Remove obsolete work around for shadow drawing (flutter/flutter#131066) 2023-07-21 [email protected] Manual roll Flutter Engine from acb5d0640b6c to 2d8cff44261b (3 revisions) (flutter/flutter#131092) 2023-07-21 [email protected] Upgrade to newer leak_tracker. (flutter/flutter#131085) 2023-07-21 [email protected] Manual roll Flutter Engine from f5c1650c7acc to acb5d0640b6c (10 revisions) (flutter/flutter#131070) 2023-07-21 [email protected] Suggest a potential valid name for the flutter project when using `flutter create` (flutter/flutter#130900) 2023-07-21 [email protected] [CI/FTL] Oriole to Panther, presubmit false (flutter/flutter#130912) 2023-07-21 [email protected] Improve handling of certain icons in RTL (flutter/flutter#130979) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130737.