Skip to content

Conversation

@HansMuller
Copy link
Contributor

@HansMuller HansMuller commented Jul 19, 2023

The existing ThemeData API doc and example "snippets" were outdated and misleading. Replaced them with one new example. Try it here: https://dartpad.dev/?id=3b03a274a5fc43c603dd989e2dbd2248&channel=master

Light Dark
Screenshot 2023-07-19 at 4 52 58 PM   Screenshot 2023-07-19 at 4 54 26 PM

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Jul 19, 2023
@HansMuller HansMuller force-pushed the update_theme_data_doc branch from bfe0ab0 to 5f0a020 Compare July 20, 2023 00:10
@HansMuller HansMuller force-pushed the update_theme_data_doc branch from 5f0a020 to 7006979 Compare July 20, 2023 03:39
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@HansMuller HansMuller merged commit 93f7dc3 into flutter:master Jul 20, 2023
@HansMuller HansMuller deleted the update_theme_data_doc branch July 20, 2023 20:12
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 21, 2023
Roll Flutter from d07e8ae to 9cfbf6b (58 revisions)

flutter/flutter@d07e8ae...9cfbf6b

2023-07-21 [email protected] Roll Packages from 674179f to 2266a76 (6 revisions) (flutter/flutter#131058)
2023-07-21 [email protected] Add tests for navigation_drawer_theme_test.dart  (flutter/flutter#130465)
2023-07-21 [email protected] Roll Flutter Engine from f812cf373b6b to f5c1650c7acc (1 revision) (flutter/flutter#131037)
2023-07-21 [email protected] Roll Flutter Engine from 264685f0aecb to f812cf373b6b (1 revision) (flutter/flutter#131032)
2023-07-21 [email protected] Roll Flutter Engine from 8ff10f5a7667 to 264685f0aecb (1 revision) (flutter/flutter#131031)
2023-07-21 [email protected] Roll Flutter Engine from b5a6b1c9cba5 to 8ff10f5a7667 (5 revisions) (flutter/flutter#131029)
2023-07-21 [email protected] Roll Flutter Engine from 218b71cd7a45 to b5a6b1c9cba5 (1 revision) (flutter/flutter#131025)
2023-07-21 [email protected] Roll Flutter Engine from ab7d424d4467 to 218b71cd7a45 (2 revisions) (flutter/flutter#131024)
2023-07-21 [email protected] Use downgraded analyze for flutter/packages (flutter/flutter#130878)
2023-07-21 [email protected] Roll pub packages (flutter/flutter#131022)
2023-07-20 [email protected] Roll Flutter Engine from 9b2ebf2afe00 to ab7d424d4467 (4 revisions) (flutter/flutter#131015)
2023-07-20 [email protected] Add applyFocusChangeIfNeeded, have menus restore focus before activating (flutter/flutter#130536)
2023-07-20 [email protected] Migrate more integration tests to process result matcher (flutter/flutter#130994)
2023-07-20 [email protected] Roll Flutter Engine from 062079ba30b6 to 9b2ebf2afe00 (2 revisions) (flutter/flutter#131013)
2023-07-20 [email protected] Trivial grammar and wrapping fix for docs (flutter/flutter#130955)
2023-07-20 [email protected] Updated the ThemeData API example (flutter/flutter#130954)
2023-07-20 [email protected] Roll Flutter Engine from a3fc18514cd6 to 062079ba30b6 (3 revisions) (flutter/flutter#131010)
2023-07-20 [email protected] Roll Flutter Engine from 6d7842d25f81 to a3fc18514cd6 (2 revisions) (flutter/flutter#131007)
2023-07-20 [email protected] Update `TextSelectionTheme`, `ThemeData`, `TimePicker`, and `TimePickerTheme` tests for M2/M3 (flutter/flutter#130547)
2023-07-20 [email protected] Roll Flutter Engine from c645eb6da8a9 to 6d7842d25f81 (1 revision) (flutter/flutter#130992)
2023-07-20 [email protected] Update AutoComplete test for M3 migration (flutter/flutter#130883)
2023-07-20 [email protected] Update about tests for M3 (flutter/flutter#130970)
2023-07-20 [email protected] Roll Packages from 209db21 to 674179f (4 revisions) (flutter/flutter#130989)
2023-07-20 [email protected] Roll Flutter Engine from e40995da7869 to c645eb6da8a9 (1 revision) (flutter/flutter#130988)
2023-07-20 [email protected] Upgrade leak_tracker. (flutter/flutter#130951)
2023-07-20 [email protected] Roll Flutter Engine from 2df3b9c4b2a4 to e40995da7869 (2 revisions) (flutter/flutter#130985)
2023-07-20 [email protected] Roll Flutter Engine from b494143fb0bc to 2df3b9c4b2a4 (3 revisions) (flutter/flutter#130973)
2023-07-20 [email protected] Fix chip delete button tap target spilling into the label. (flutter/flutter#130896)
2023-07-20 [email protected] Fix IconButton leaks its internal MaterialStatesController (flutter/flutter#130720)
2023-07-20 [email protected] Update banner_theme_test.dart for M3 (flutter/flutter#130884)
2023-07-20 [email protected] Roll Flutter Engine from 204625490ca1 to b494143fb0bc (1 revision) (flutter/flutter#130966)
2023-07-20 [email protected] Make PollingDeviceDiscovery start the initial poll faster. (flutter/flutter#130755)
2023-07-20 [email protected] Roll Flutter Engine from c902fec1e3ce to 204625490ca1 (1 revision) (flutter/flutter#130962)
2023-07-20 [email protected] More documentation for MediaQuery and friends (flutter/flutter#130509)
2023-07-20 [email protected] Roll Flutter Engine from 56e88e8b0eef to c902fec1e3ce (1 revision) (flutter/flutter#130960)
2023-07-20 [email protected] Automatically create the layer when setting hints in PaintingContext (flutter/flutter#130364)
2023-07-20 [email protected] Roll Flutter Engine from e2a36be2f084 to 56e88e8b0eef (1 revision) (flutter/flutter#130959)
2023-07-20 [email protected] Further clarify Stack documentation on overflowing (flutter/flutter#130776)
2023-07-20 [email protected] Roll Flutter Engine from eff70f7287f9 to e2a36be2f084 (2 revisions) (flutter/flutter#130956)
2023-07-20 [email protected] Can traverse if current focused node skips traversal (flutter/flutter#130812)
2023-07-20 [email protected] Document that you can't change initialRoute usefully (flutter/flutter#130450)
2023-07-20 [email protected] Roll Flutter Engine from 7671e2f2a9fc to eff70f7287f9 (3 revisions) (flutter/flutter#130953)
2023-07-19 [email protected] Roll Flutter Engine from 938140a974b0 to 7671e2f2a9fc (3 revisions) (flutter/flutter#130948)
2023-07-19 [email protected] Roll Flutter Engine from 0af285219809 to 938140a974b0 (1 revision) (flutter/flutter#130943)
2023-07-19 [email protected] Add docs to Route.maintainState (flutter/flutter#130638)
2023-07-19 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.20.4 to 2.21.0 (flutter/flutter#130941)
...
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants