Add the 'a: desktop' label to labeler.yml #130933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyHillers
approved these changes
Jul 19, 2023
.github/labeler.yml
Outdated
| - '**/*animation*' | ||
|
|
||
| 'a: desktop': | ||
| - '**/linux/*' |
Contributor
There was a problem hiding this comment.
Should these have an additional directory wildcard at the end?
- '**/linux/**/*'
Member
Author
There was a problem hiding this comment.
That's what I thought too, but strangely the other paths don't seem to follow that pattern. For example, material definitely has nested folders, yet its pattern is `**/material/*. I'll add the additional directory wildcard
loic-sharma
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter, pr: 130933, due to - The status or check suite Windows build_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
cbracken
approved these changes
Jul 21, 2023
Member
Author
|
@cbracken That was the engine repo's version of this pull request :) |
goderbauer
added
the
c: contributor-productivity
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 27, 2023
tarrinneal
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 27, 2023
Manual roll requested by [email protected] flutter/flutter@bae1ac2...61fd11d 2023-07-26 [email protected] Add the 'a: desktop' label to labeler.yml (flutter/flutter#130933) 2023-07-26 [email protected] ImageDecoration.lerp (#130533) (flutter/flutter#131349) 2023-07-26 [email protected] Minor adjustments on 2D APIs (flutter/flutter#131358) 2023-07-26 [email protected] Revert "Update Unit Tests for M2/M3" (flutter/flutter#131368) 2023-07-26 [email protected] Update Unit Tests for M2/M3 (flutter/flutter#131292) 2023-07-26 [email protected] Revert "Run benchmarks with `--omit-type-checks`" (flutter/flutter#131353) 2023-07-26 [email protected] Revert "ImageDecoration.lerp" (flutter/flutter#131347) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
The desktop team uses the [`a: desktop`](https://github.com/flutter/engine/pulls?q=is%3Aopen+label%3A%22affects%3A+desktop%22+sort%3Aupdated-desc) label to [triage](https://github.com/flutter/flutter/wiki/Triage#desktop-platforms-team-team-desktop) pull requests.
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
The desktop team uses the [`a: desktop`](https://github.com/flutter/engine/pulls?q=is%3Aopen+label%3A%22affects%3A+desktop%22+sort%3Aupdated-desc) label to [triage](https://github.com/flutter/flutter/wiki/Triage#desktop-platforms-team-team-desktop) pull requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The desktop team uses the
a: desktoplabel to triage pull requests.