Skip to content

Reland "Print pretty error when xcodebuild fails due to missing simulator #130286" #130506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Jul 13, 2023
Merged

Reland "Print pretty error when xcodebuild fails due to missing simulator #130286" #130506

auto-submit merged 2 commits into from
Jul 13, 2023

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented Jul 13, 2023 •
edited
Loading

Reland #130286 with fix.

It failed the first time because of a discrepancy between the master branch and my branch (see #130504 (comment) for more info).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 13, 2023
christopherfujino
christopherfujino approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 13, 2023
@auto-submit auto-submit bot merged commit 2892b57 into flutter:master Jul 13, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
64180d4 
…ng simulator #130286" (flutter/flutter#130506)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
7dc6772 
…ng simulator #130286" (flutter/flutter#130506)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
12bcedb 
…ng simulator #130286" (flutter/flutter#130506)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
85be3ce 
…ng simulator #130286" (flutter/flutter#130506)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
8e88a75 
…ng simulator #130286" (flutter/flutter#130506)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
f757174 
…ng simulator #130286" (flutter/flutter#130506)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
10812fb 
…ng simulator #130286" (flutter/flutter#130506)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
7b1467d 
…ng simulator #130286" (flutter/flutter#130506)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
dbfadc9 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
48d5da8 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
eef76da 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
e00939f 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
75bb8f7 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
8f0f1ed 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
2f69e38 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
ad370cd 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
b07d181 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
7257d0c 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
2a66a0e 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
c021929 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
4386fb9 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
efbac97 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
4f52e95 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
cfabecf 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
401d813 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
a1be7c9 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
91a8c1e 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
ec405d4 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
9ca97ae 
…ng simulator #130286" (flutter/flutter#130506)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
2892b57 Reland "Print pretty error when xcodebuild fails due to missi…
b272d55 
…ng simulator #130286" (flutter/flutter#130506)
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@vashworth @LouiseHsu
Reland "Print pretty error when xcodebuild fails due to missing simul…
72b647b 
…ator flutter#130286" (flutter#130506)

Reland flutter#130286 with fix.

It failed the first time because of a discrepancy between the master branch and my branch (see flutter#130504 (comment) for more info).
vashworth added a commit to vashworth/flutter that referenced this pull request Aug 9, 2023
@vashworth
Reland "Print pretty error when xcodebuild fails due to missing simul…
b4ba342 
…ator flutter#130286" (flutter#130506)

Reland flutter#130286 with fix.

It failed the first time because of a discrepancy between the master branch and my branch (see flutter#130504 (comment) for more info).
@vashworth vashworth mentioned this pull request Aug 9, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request Aug 14, 2023
@vashworth
[CP] Print pretty error when xcodebuild fails due to missing simulator (
ff8ade8 
#132235)

Original PR: #130506

Note:
I added a commit to fix a name discrepancy.

[A commit on master](https://github.com/flutter/flutter/pull/130156/files#diff-157aa748cf5e84d2d03141150ddf4136e24635f1a1d50fc52e1da2354a70ac83L1043), that was added prior to the CP PR, renamed a variable from `_xcBundleFilePath` -> `_xcBundleDirectoryPath`. The CP PR uses the new name since it came after the first commit, so I added a commit to this PR to use the old variable name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vashworth @christopherfujino