Skip to content

Revert "Print pretty error when xcodebuild fails due to missing simulator" #130504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jul 13, 2023
Merged

Revert "Print pretty error when xcodebuild fails due to missing simulator" #130504

auto-submit merged 1 commit into from
Jul 13, 2023

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented Jul 13, 2023 •
edited
Loading

Reverts #130286

Failed on

 Failed to load "test/commands.shard/hermetic/build_ios_test.dart":
  test/commands.shard/hermetic/build_ios_test.dart:663:57: Error: Undefined name '_xcBundleFilePath'.
            fileSystem.systemTempDirectory.childDirectory(_xcBundleFilePath).createSync();

https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20tool_tests_commands/11941/overview

This occurred because the variable was renamed in a commit on master, but my branch wasn't update to date and it didn't have a merge conflict because I added new code (that used the old variable name).

@vashworth vashworth added the revert Autorevert PR (with "Reason for revert:" comment) label Jul 13, 2023
@github-actions github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 13, 2023
@auto-submit auto-submit bot merged commit ab86c79 into master Jul 13, 2023
@auto-submit auto-submit bot deleted the revert-130286-missing_ios_17_sim_err_message branch July 13, 2023 17:19
vashworth added a commit to vashworth/flutter that referenced this pull request Jul 13, 2023
@vashworth
Reland "Print pretty error when xcodebuild fails due to missing simul…
4dc394d 
…ator" (flutter#130504)

This reverts commit ab86c79.
@vashworth vashworth mentioned this pull request Jul 13, 2023
Merged
8 tasks
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 13, 2023
@vashworth @LouiseHsu
Revert "Print pretty error when xcodebuild fails due to missing simul…
b334efc 
…ator" (flutter#130504)

Reverts flutter#130286
auto-submit bot pushed a commit that referenced this pull request Jul 13, 2023
@vashworth
Reland "Print pretty error when xcodebuild fails due to missing simul…
2892b57 
…ator #130286" (#130506)

Reland #130286 with fix.

It failed the first time because of a discrepancy between the master branch and my branch (see #130504 (comment) for more info).
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
9c5e499 
…ng simulator" (flutter/flutter#130504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
2ba55b2 
…ng simulator" (flutter/flutter#130504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
ef8958f 
…ng simulator" (flutter/flutter#130504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
df745d3 
…ng simulator" (flutter/flutter#130504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
7b15818 
…ng simulator" (flutter/flutter#130504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
7b7d07d 
…ng simulator" (flutter/flutter#130504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
5fc86f0 
…ng simulator" (flutter/flutter#130504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
0852d06 
…ng simulator" (flutter/flutter#130504)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
b528656 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
073aa24 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
6f8e6fa 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
d1b1cbc 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
d951c13 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
8be7dd0 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
e34dafd 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
f416e95 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
ee4d6dd 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
d1b9ac4 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
c924172 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
d748293 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
ee95f11 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
db5c56d 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
7ec636e 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
94e2261 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
543afae 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
f80eed3 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
7228131 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
7292aea 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
157dcf8 
…ng simulator" (flutter/flutter#130504)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
ab86c79 Revert "Print pretty error when xcodebuild fails due to missi…
5cc3e1d 
…ng simulator" (flutter/flutter#130504)
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@vashworth @LouiseHsu
Reland "Print pretty error when xcodebuild fails due to missing simul…
72b647b 
…ator flutter#130286" (flutter#130506)

Reland flutter#130286 with fix.

It failed the first time because of a discrepancy between the master branch and my branch (see flutter#130504 (comment) for more info).
vashworth added a commit to vashworth/flutter that referenced this pull request Aug 9, 2023
@vashworth
Reland "Print pretty error when xcodebuild fails due to missing simul…
b4ba342 
…ator flutter#130286" (flutter#130506)

Reland flutter#130286 with fix.

It failed the first time because of a discrepancy between the master branch and my branch (see flutter#130504 (comment) for more info).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees

No one assigned

Labels

platform-ios iOS applications specifically revert Autorevert PR (with "Reason for revert:" comment) tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vashworth @fluttergithubbot