Repository navigation
Reenable fade transition for Material page transition - #13048
Merged
Merged
Conversation
Fixes flutter#12877 by reverting flutter#9472
Contributor
|
What are the performance implications of this patch? |
Contributor
|
I guess we'll find out when it lands. |
Contributor
|
Thanks! Landing. |
Contributor
|
This massively regressed a number of our benchmarks. I'm going to revert this again for now. |
Contributor
|
See #13172 for the revert. |
Contributor
Hixie
added a commit
that referenced
this pull request
Nov 23, 2017
Contributor
Author
|
Great this project has benchmarks! |
Hixie
pushed a commit
to Hixie/flutter
that referenced
this pull request
Dec 19, 2017
Hixie
added a commit
that referenced
this pull request
Dec 20, 2017
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
…r#13048)" (flutter#13172) This reverts commit e73d406. It caused major performance regressions.
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 10, 2019
engine-flutter-autoroll
added a commit
that referenced
this pull request
Oct 10, 2019
[email protected]:flutter/engine.git/compare/5162413111b8...cef6751 git log 5162413..cef6751 --no-merges --oneline 2019-10-10 [email protected] Revert "Test child isolates are terminated when root is shutdown (#13048)" (flutter-team-archive/engine#13067) 2019-10-10 [email protected] Test child isolates are terminated when root is shutdown (flutter-team-archive/engine#13048) 2019-10-10 [email protected] Allow embedders to specify arbitrary data to the isolate on launch. (flutter-team-archive/engine#13047) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
[email protected]:flutter/engine.git/compare/5162413111b8...cef6751 git log 5162413..cef6751 --no-merges --oneline 2019-10-10 [email protected] Revert "Test child isolates are terminated when root is shutdown (flutter#13048)" (flutter-team-archive/engine#13067) 2019-10-10 [email protected] Test child isolates are terminated when root is shutdown (flutter-team-archive/engine#13048) 2019-10-10 [email protected] Allow embedders to specify arbitrary data to the isolate on launch. (flutter-team-archive/engine#13047) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12877 by reverting #9472