Skip to content

Revert "Roll Flutter Engine from 16e2ab7e986c to 1b1ccdd1f527 (13 revisions)" #130479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zanderso merged 1 commit into from
Jul 13, 2023
Merged

Revert "Roll Flutter Engine from 16e2ab7e986c to 1b1ccdd1f527 (13 revisions)" #130479

zanderso merged 1 commit into from
Jul 13, 2023

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Jul 13, 2023

Reverts #130458

@flutter-dashboard
Copy link

flutter-dashboard bot commented Jul 13, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jonahwilliams jonahwilliams added autosubmit Merge PR when tree becomes green via auto submit App revert Autorevert PR (with "Reason for revert:" comment) labels Jul 13, 2023
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Jul 13, 2023
@jonahwilliams jonahwilliams added warning: land on red to fix tree breakage and removed engine flutter/engine related. See also e: labels. labels Jul 13, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 13, 2023

auto label is removed for flutter/flutter, pr: 130479, due to This PR has not met approval requirements for merging. You are a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 13, 2023
@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 13, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 13, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 13, 2023

auto label is removed for flutter/flutter, pr: 130479, due to This PR has not met approval requirements for merging. You are a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Jul 13, 2023

well, I tried

@zanderso
Copy link
Member

zanderso commented Jul 13, 2023

@ricardoamador Do you know why the revert bot couldn't revert this PR?

@zanderso zanderso merged commit c40173f into master Jul 13, 2023
@zanderso zanderso deleted the revert-130458-flutter-engine-flutter-autoroll-6726ba88-0fe8-475e-ae37-e4e06212672b-1689204557 branch July 13, 2023 15:02
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 13, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 13, 2023
@engine-flutter-autoroll
c40173f Revert "Roll Flutter Engine from 16e2ab7e986c to 1b1ccdd1f527…
5876716 
… (13 revisions)" (flutter/flutter#130479)
@ricardoamador
Copy link
Contributor

ricardoamador commented Jul 13, 2023

Yes, you need to add the 'revert' label and not the 'autosubmit' label. But this will be simplified shortly.

auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 13, 2023
@engine-flutter-autoroll
Roll Flutter from 544d30d to c40173f (10 revisions) (#4457)
d70eed0 
flutter/flutter@544d30d...c40173f

2023-07-13 [email protected] Revert "Roll Flutter Engine from 16e2ab7e986c to 1b1ccdd1f527 (13 revisions)" (flutter/flutter#130479)
2023-07-13 [email protected] Roll Flutter Engine from 16e2ab7e986c to 1b1ccdd1f527 (13 revisions) (flutter/flutter#130458)
2023-07-13 [email protected] Exclude `Tooltip`'s overlay child from SelectableRegion (flutter/flutter#130181)
2023-07-12 [email protected] Update `Checkbox` tests for M2/M3 (flutter/flutter#130351)
2023-07-12 [email protected] Refactor JSNumber.toDart and Object.toJS (flutter/flutter#129436)
2023-07-12 [email protected]  Reland [a11y] CupertinoSwitch On/Off labels (flutter/flutter#130173)
2023-07-12 [email protected] Add missing links to examples that aren't linked anywhere (flutter/flutter#130422)
2023-07-12 [email protected] Use platform specific line separator in gen-l10n (flutter/flutter#130090)
2023-07-12 [email protected] Update `Divider`/`VerticalDivider` and theme tests for M2/M3 (flutter/flutter#130415)
2023-07-12 [email protected] Roll Flutter Engine from 5c887028810d to 16e2ab7e986c (2 revisions) (flutter/flutter#130421)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 13, 2023
@LouiseHsu
Revert "Roll Flutter Engine from 16e2ab7e986c to 1b1ccdd1f527 (13 rev…
b77b1bb 
…isions)" (flutter#130479)

Reverts flutter#130458
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

Assignees

No one assigned

Labels

revert Autorevert PR (with "Reason for revert:" comment)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonahwilliams @zanderso @ricardoamador