Skip to content

[flutter_tools] remove desktop device restrictions on Impeller. #130430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Jul 13, 2023
Merged

[flutter_tools] remove desktop device restrictions on Impeller. #130430

auto-submit merged 2 commits into from
Jul 13, 2023

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Jul 12, 2023

All current desktop backends will support Impeller after flutter/engine#43388 lands.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 12, 2023
christopherfujino
christopherfujino approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 13, 2023
@auto-submit auto-submit bot merged commit 60c1f37 into flutter:master Jul 13, 2023
@jonahwilliams jonahwilliams deleted the remove_desktop_restriction branch July 13, 2023 16:43
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 13, 2023
@LouiseHsu
[flutter_tools] remove desktop device restrictions on Impeller. (flut…
3b9058e 
…ter#130430)

All current desktop backends will support Impeller after flutter/engine#43388 lands.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
c8352aa 
…r. (flutter/flutter#130430)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
50ca666 
…r. (flutter/flutter#130430)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
e87de6d 
…r. (flutter/flutter#130430)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
f47e645 
…r. (flutter/flutter#130430)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
164043e 
…r. (flutter/flutter#130430)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
e89ac10 
…r. (flutter/flutter#130430)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
617e160 
…r. (flutter/flutter#130430)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
5852f53 
…r. (flutter/flutter#130430)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
f3e3577 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
442159e 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
dc07401 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
554fa09 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
ee64c2c 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
5cd00f7 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
1213547 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
61dc090 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
ec013bf 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
4fbcb9d 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
075c7d8 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
225f5d3 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
70eacbb 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
2742dc9 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
210b1ec 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
27fe66c 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
41b5e57 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
1388f94 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
4ebb830 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
d5e2f3f 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
06adaba 
…r. (flutter/flutter#130430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
60c1f37 [flutter_tools] remove desktop device restrictions on Impelle…
704366f 
…r. (flutter/flutter#130430)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams @christopherfujino