Paginated Data Table : Fixed Row number at footer in last page #130389

aakash-pamnani · 2023-07-12T07:32:06Z

Fixed the row count in the footer.

Before

After

Issues Resolved
Fixes #116569

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…n fotter

flutter-dashboard · 2023-07-12T07:32:09Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Piinks

Hi @aakash-pamnani! Welcome, and thanks for contributing. It looks like this PR is addressing two separate issues. Can you split them up into separate PRs? Thank you!

Piinks · 2023-07-24T18:27:45Z

packages/flutter/test/material/paginated_data_table_test.dart

    log.clear();
  });

+  testWidgets('PaginatedDataTable fotter page number', (WidgetTester tester) async {


Suggested change

testWidgets('PaginatedDataTable fotter page number', (WidgetTester tester) async {

testWidgets('PaginatedDataTable footer page number', (WidgetTester tester) async {

Piinks · 2023-07-24T18:29:12Z

packages/flutter/lib/src/material/paginated_data_table.dart

        localizations.pageRowsInfoTitle(
          _firstRowIndex + 1,
-          _firstRowIndex + widget.rowsPerPage,
+          (_firstRowIndex + widget.rowsPerPage) > _rowCount ? _rowCount : (_firstRowIndex + widget.rowsPerPage),


Can you split this out into a separate pull request? Trying to fix multiple things with this widget is great! However, it would be a shame if one part of this PR was reverted because the other part created an unforeseen issue. :)

Sure I will create a new PR for the new parameters, I didn't thought about this. Thanks

Could this be a min function?

Suggested change

(_firstRowIndex + widget.rowsPerPage) > _rowCount ? _rowCount : (_firstRowIndex + widget.rowsPerPage),

math.min(_firstRowIndex + widget.rowsPerPage, _rowCount),

packages/flutter/lib/src/material/paginated_data_table.dart

aakash-pamnani · 2023-07-27T18:39:20Z

Hi @Piinks I have removed one fix from this PR, will create a new PR once the test's are ready.

Piinks

Thank you for the update! I think just a small tweak below - using a min function is probably a bit more reader friendly. :)

aakash-pamnani · 2023-07-28T06:29:30Z

Done

Piinks

gibahjoe · 2023-07-29T21:04:47Z

I do not think this pr fixes #80421 as advertised because #80421 talks about phantom rows which is still visible in your After photo.

aakash-pamnani · 2023-07-30T01:54:21Z

I do not think this pr fixes #80421 as advertised because #80421 talks about phantom rows which is still visible in your After photo.

Someone in #80421 commented that "The toolbar is then halfway down the page instead of at the bottom of the page." And that does not meet the material design standards.
And it actually resolves #116569 but it is closed with comments "duplicate of #80421 "

justinmc

LGTM 👍

There was a test failure but it seems to be an infrastructure problem, so I've rerun it.

justinmc · 2023-07-31T16:00:32Z

packages/flutter/test/material/paginated_data_table_test.dart

+
+    expect(find.text('497–500 of 500'), findsOneWidget);
+
+


Remove this extra newline here.

Hi @justinmc, removed the newline.

flutter/flutter#130389)

flutter/flutter@436df69...f4c25bb 2023-08-09 [email protected] Revert "Handle breaking changes in leak_tracker." (flutter/flutter#132223) 2023-08-09 [email protected] Roll Flutter Engine from 8ec575168d44 to 3d3fb4faed02 (3 revisions) (flutter/flutter#132193) 2023-08-09 [email protected] Use pattern matching to avoid strange type annotations (flutter/flutter#131964) 2023-08-09 [email protected] Roll Flutter Engine from 6839b88283b6 to 8ec575168d44 (1 revision) (flutter/flutter#132182) 2023-08-09 [email protected] Roll Flutter Engine from 29b117aa4192 to 6839b88283b6 (1 revision) (flutter/flutter#132181) 2023-08-09 [email protected] Roll Flutter Engine from 82292b8390cb to 29b117aa4192 (5 revisions) (flutter/flutter#132179) 2023-08-09 [email protected] Add more info to `OverlayState.insert` error messages (flutter/flutter#129363) 2023-08-08 [email protected] Add `textCapitalization` property for `SearchBar` and `SearchAnchor` (flutter/flutter#131459) 2023-08-08 [email protected] Roll Flutter Engine from 934ebb005d02 to 82292b8390cb (3 revisions) (flutter/flutter#132166) 2023-08-08 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.2 to 2.21.3 (flutter/flutter#132165) 2023-08-08 [email protected] Revert of #120385 (flutter/flutter#132167) 2023-08-08 [email protected] Add `PopupMenuButton.iconColor`, `PopupMenuTheme.iconSize` and fix button icon using unexpected color propert (flutter/flutter#132054) 2023-08-08 [email protected] More PageStorage clarity in the documentation (flutter/flutter#131954) 2023-08-08 [email protected] Document that missed_frame_build_budget_count is misleading (flutter/flutter#132137) 2023-08-08 [email protected] Locate the template directory using a TemplatePathProvider. (flutter/flutter#132156) 2023-08-08 [email protected] Roll Flutter Engine from dd03fae51d38 to 934ebb005d02 (4 revisions) (flutter/flutter#132159) 2023-08-08 [email protected] Roll Flutter Engine from 22bd35a19352 to dd03fae51d38 (3 revisions) (flutter/flutter#132149) 2023-08-08 [email protected] Fix `TabBarTheme.indicatorColor` not applied in Material 2 (flutter/flutter#132123) 2023-08-08 [email protected] Paginated Data Table : Fixed Row number at footer in last page (flutter/flutter#130389) 2023-08-08 [email protected] [web] Use benchmark callback from `dart:ui_web` (flutter/flutter#132087) 2023-08-08 [email protected] Roll Flutter Engine from 99fdac88f3c6 to 22bd35a19352 (3 revisions) (flutter/flutter#132141) 2023-08-08 [email protected] [framework] Add Search Web to selection controls for iOS (flutter/flutter#131898) 2023-08-08 [email protected] Remove Iterator from _History (flutter/flutter#132101) 2023-08-08 [email protected] Update dartdoc driver to match current behaviour (flutter/flutter#132078) 2023-08-08 [email protected] More documentation about warm-up frames (flutter/flutter#132085) 2023-08-08 [email protected] Roll Flutter Engine from 146c4c9487fc to 99fdac88f3c6 (3 revisions) (flutter/flutter#132135) 2023-08-08 [email protected] Roll Packages from d7ee75a to ac41376 (8 revisions) (flutter/flutter#132133) 2023-08-08 [email protected] Handle breaking changes in leak_tracker. (flutter/flutter#131998) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/flutter#130389)

aakash-pamnani and others added 5 commits July 12, 2023 10:54

Added missing parameters in PaginatedDataTable and fixed no of rows i…

1c3d8f8

…n fotter

revert formatting changes

efc61f8

Merge branch 'flutter:master' into master

a02ca64

Fixed: Row number in fotter if last page rows are empty

f39502c

Merge branch 'master' of https://github.com/aakash-pamnani/flutter

8db6ca1

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 12, 2023

aakash-pamnani and others added 3 commits July 12, 2023 14:00

Merge branch 'master' into master

fd32064

Merge branch 'flutter:master' into master

5129a26

Added test for paginated data table page number

9843c32

HansMuller changed the title ~~Paginated Data Table : Fixed Row number at fotter in last page & added missing parameters.~~ Paginated Data Table : Fixed Row number at footer in last page & added missing parameters. Jul 21, 2023

Piinks self-requested a review July 21, 2023 22:07

Piinks reviewed Jul 24, 2023

View reviewed changes

Piinks mentioned this pull request Jul 24, 2023

Add missing parameters to PaginatedDataTable. #130226

Closed

8 tasks

aakash-pamnani and others added 4 commits July 25, 2023 15:07

Merge branch 'flutter:master' into master

3339a4d

Removed additional parameters from PaginatedDataTable

ba8fd61

Merge branch 'master' of https://github.com/aakash-pamnani/flutter

1b121bb

Merge branch 'master' into master

9711091

aakash-pamnani requested a review from Piinks July 26, 2023 06:31

Merge branch 'master' into master

1278486

Piinks changed the title ~~Paginated Data Table : Fixed Row number at footer in last page & added missing parameters.~~ Paginated Data Table : Fixed Row number at footer in last page Jul 27, 2023

Piinks reviewed Jul 27, 2023

View reviewed changes

Replaced paginated data rable fotter number with min function

b4b1f05

Piinks approved these changes Jul 28, 2023

View reviewed changes

Merge branch 'master' into master

1752150

justinmc approved these changes Jul 31, 2023

View reviewed changes

aakash-pamnani added 2 commits July 31, 2023 22:55

Update paginated_data_table_test.dart

155adcd

Merge branch 'master' into master

a94ff4d

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2023

auto-submit bot merged commit 0b81347 into flutter:master Aug 8, 2023

engine-flutter-autoroll mentioned this pull request Aug 9, 2023

Roll Flutter from 436df69a4684 to d78b3ac0af0e (27 revisions) flutter/packages#4665

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 9, 2023

0b81347 Paginated Data Table : Fixed Row number at footer in last page (

42e9848

flutter/flutter#130389)

engine-flutter-autoroll mentioned this pull request Aug 9, 2023

Roll Flutter from 436df69a4684 to f4c25bbb351c (28 revisions) flutter/packages#4666

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 9, 2023

0b81347 Paginated Data Table : Fixed Row number at footer in last page (

1b8faa4

flutter/flutter#130389)

TahaTesser mentioned this pull request Aug 10, 2023

paginatedDataTable showing empty rows at the end if rowCount is less than rowsPerPage #80421

Closed

HansMuller mentioned this pull request Aug 11, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

0b81347 Paginated Data Table : Fixed Row number at footer in last page (

a9a016d

flutter/flutter#130389)

	testWidgets('PaginatedDataTable fotter page number', (WidgetTester tester) async {
	testWidgets('PaginatedDataTable footer page number', (WidgetTester tester) async {

	(_firstRowIndex + widget.rowsPerPage) > _rowCount ? _rowCount : (_firstRowIndex + widget.rowsPerPage),
	math.min(_firstRowIndex + widget.rowsPerPage, _rowCount),

Paginated Data Table : Fixed Row number at footer in last page #130389

Paginated Data Table : Fixed Row number at footer in last page #130389

Uh oh!

Conversation

aakash-pamnani commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Jul 12, 2023

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks Jul 24, 2023

Choose a reason for hiding this comment

Uh oh!

Piinks Jul 24, 2023

Choose a reason for hiding this comment

Uh oh!

aakash-pamnani Jul 25, 2023

Choose a reason for hiding this comment

Uh oh!

Piinks Jul 27, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aakash-pamnani commented Jul 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

aakash-pamnani commented Jul 28, 2023

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

gibahjoe commented Jul 29, 2023

Uh oh!

aakash-pamnani commented Jul 30, 2023

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Jul 31, 2023

Choose a reason for hiding this comment

Uh oh!

aakash-pamnani Jul 31, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aakash-pamnani commented Jul 12, 2023 •

edited

Loading

aakash-pamnani commented Jul 27, 2023 •

edited

Loading