Skip to content

Fix Finnish translation for tab labels #130333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Jul 14, 2023
Merged

Fix Finnish translation for tab labels #130333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/flutter_localizations/lib/src/l10n/cupertino_fi.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"copyButtonLabel": "Kopioi",
"pasteButtonLabel": "Liitä",
"selectAllButtonLabel": "Valitse kaikki",
"tabSemanticsLabel": "Välilehti $tabIndex/$tabCount",
"tabSemanticsLabel": "Välilehti $tabIndex kautta $tabCount",
"modalBarrierDismissLabel": "Ohita",
"searchTextFieldPlaceholderLabel": "Hae",
"noSpellCheckReplacementsLabel": "No Replacements Found"
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_localizations/lib/src/l10n/generated_cupertino_localizations.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3983,7 +3983,7 @@ class CupertinoLocalizationFi extends GlobalCupertinoLocalizations {
String get selectAllButtonLabel => 'Valitse kaikki';

@override
String get tabSemanticsLabelRaw => r'Välilehti $tabIndex/$tabCount';
String get tabSemanticsLabelRaw => r'Välilehti $tabIndex kautta $tabCount';

@override
String? get timerPickerHourLabelFew => null;
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_localizations/lib/src/l10n/generated_material_localizations.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14206,7 +14206,7 @@ class MaterialLocalizationFi extends GlobalMaterialLocalizations {
String get signedInLabel => 'Kirjautunut sisään';

@override
String get tabLabelRaw => r'Välilehti $tabIndex/$tabCount';
String get tabLabelRaw => r'Välilehti $tabIndex kautta $tabCount';

@override
TimeOfDayFormat get timeOfDayFormatRaw => TimeOfDayFormat.HH_dot_mm;
Expand Down
2 changes: 1 addition & 1 deletion packages/flutter_localizations/lib/src/l10n/material_fi.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"pageRowsInfoTitle": "$firstRow–$lastRow/$rowCount",
"pageRowsInfoTitleApproximate": "$firstRow–$lastRow/~$rowCount",
"rowsPerPageTitle": "Riviä/sivu:",
"tabLabel": "Välilehti $tabIndex/$tabCount",
"tabLabel": "Välilehti $tabIndex kautta $tabCount",
"selectedRowCountTitleOne": "1 kohde valittu",
"selectedRowCountTitleOther": "$selectedRowCount kohdetta valittu",
"cancelButtonLabel": "Peru",
Expand Down
9 changes: 9 additions & 0 deletions packages/flutter_localizations/test/cupertino/translations_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,4 +194,13 @@ void main() {
expect(file.readAsStringSync(), encodedArbFile);
}
});

// Regression test for https://github.com/flutter/flutter/issues/110451.
testWidgets('Finnish translation for tab label', (WidgetTester tester) async {
const Locale locale = Locale('fi');
expect(GlobalCupertinoLocalizations.delegate.isSupported(locale), isTrue);
final CupertinoLocalizations localizations = await GlobalCupertinoLocalizations.delegate.load(locale);
expect(localizations, isA<CupertinoLocalizationFi>());
expect(localizations.tabSemanticsLabel(tabIndex: 1, tabCount: 2), 'Välilehti 1 kautta 2');
});
}
9 changes: 9 additions & 0 deletions packages/flutter_localizations/test/material/translations_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,4 +528,13 @@ void main() {
expect(file.readAsStringSync(), encodedArbFile);
}
});

// Regression test for https://github.com/flutter/flutter/issues/110451.
testWidgets('Finnish translation for tab label', (WidgetTester tester) async {
const Locale locale = Locale('fi');
expect(GlobalCupertinoLocalizations.delegate.isSupported(locale), isTrue);
final MaterialLocalizations localizations = await GlobalMaterialLocalizations.delegate.load(locale);
expect(localizations, isA<MaterialLocalizationFi>());
expect(localizations.tabLabel(tabIndex: 1, tabCount: 2), 'Välilehti 1 kautta 2');
});
}