Skip to content

Fix default icon color constants reversed brightness documentation #130231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Jul 10, 2023
Merged

Fix default icon color constants reversed brightness documentation #130231

auto-submit merged 2 commits into from
Jul 10, 2023

Conversation

@rydmike
Copy link
Contributor

@rydmike rydmike commented Jul 9, 2023

Fixes the reversed default icon color constants brightness documentation for kDefaultIconLightColor and kDefaultIconDarkColor.

FIX: #130230

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 9, 2023
@rydmike rydmike mentioned this pull request Jul 10, 2023
Closed
2 tasks
TahaTesser
TahaTesser approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TahaTesser TahaTesser added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Jul 10, 2023
@TahaTesser
Copy link
Member

TahaTesser commented Jul 10, 2023

This'll need a secondary review from @HansMuller for the autosubmit to pass.

HansMuller
HansMuller approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks for the fix!
LGTM

@HansMuller HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 10, 2023
@auto-submit auto-submit bot merged commit b828846 into flutter:master Jul 10, 2023
@rydmike rydmike deleted the fix-doc-for-default-icon-color-constants branch July 10, 2023 15:44
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2023
@engine-flutter-autoroll
b828846 Fix default icon color constants reversed brightness document…
a9169ef 
…ation (flutter/flutter#130231)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2023
@engine-flutter-autoroll
b828846 Fix default icon color constants reversed brightness document…
b1f1d28 
…ation (flutter/flutter#130231)
gbtb16 pushed a commit to gbtb16/flutter that referenced this pull request Nov 6, 2023
@rydmike @gbtb16
Fix default icon color constants reversed brightness documentation (f…
d87f878 
…lutter#130231)

Fixes the reversed default icon color constants brightness documentation for `kDefaultIconLightColor` and `kDefaultIconDarkColor`.

FIX: flutter#130230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TahaTesser TahaTesser TahaTesser approved these changes

+1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation error: The brightness values for kDefaultIconLightColor and kDefaultIconDarkColor are reversed

3 participants

@rydmike @TahaTesser @HansMuller