Reland [a11y] CupertinoSwitch On/Off labels #130173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes off label color
introduced onOffLabelColors nullable record added high contrast variant of offLabelColor
handles off label color logic
replaced goldens with PaintPatterns
github-actions
bot
added
framework
MitchellGoodwin
approved these changes
Jul 7, 2023
Contributor
MitchellGoodwin
left a comment
MitchellGoodwin
left a comment
There was a problem hiding this comment.
LGTM. Thank you for taking the time to reopen this so quickly.
justinmc
approved these changes
Jul 7, 2023
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
However, this shouldn't be merged until Google tests have run and a g3 fix has been created.
justinmc
added
the
autosubmit
Contributor
|
The fix has been applied and this is ready to merge. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 13, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 13, 2023
flutter/flutter@544d30d...c40173f 2023-07-13 [email protected] Revert "Roll Flutter Engine from 16e2ab7e986c to 1b1ccdd1f527 (13 revisions)" (flutter/flutter#130479) 2023-07-13 [email protected] Roll Flutter Engine from 16e2ab7e986c to 1b1ccdd1f527 (13 revisions) (flutter/flutter#130458) 2023-07-13 [email protected] Exclude `Tooltip`'s overlay child from SelectableRegion (flutter/flutter#130181) 2023-07-12 [email protected] Update `Checkbox` tests for M2/M3 (flutter/flutter#130351) 2023-07-12 [email protected] Refactor JSNumber.toDart and Object.toJS (flutter/flutter#129436) 2023-07-12 [email protected] Reland [a11y] CupertinoSwitch On/Off labels (flutter/flutter#130173) 2023-07-12 [email protected] Add missing links to examples that aren't linked anywhere (flutter/flutter#130422) 2023-07-12 [email protected] Use platform specific line separator in gen-l10n (flutter/flutter#130090) 2023-07-12 [email protected] Update `Divider`/`VerticalDivider` and theme tests for M2/M3 (flutter/flutter#130415) 2023-07-12 [email protected] Roll Flutter Engine from 5c887028810d to 16e2ab7e986c (2 revisions) (flutter/flutter#130421) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 13, 2023
This original PR (flutter#127776) was reverted (flutter#130166) due to a Google test failure. This reopens the PR as per the discussion in flutter#130166 (comment). Fixes issue flutter#4830.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This original PR (#127776) was reverted (#130166) due to a Google test failure.
This reopens the PR as per the discussion in #130166 (comment).
Fixes issue #4830.