Skip to content

Conversation

@aam
Copy link
Member

@aam aam commented Jul 7, 2023

Manual roll is needed because incoming dart sdk requires updated version vm_snapshot_analysis (>=0.7.4).

flutter/engine@5ae09b8...7c83ea3

7c83ea3e85 Reland "Manual roll Dart SDK from 2d98d9e27dae to 0b07debd5862 (21 revisions) (#43457)" (#43472)
9ef3e8d533 Roll Skia from 5eba922297bb to 93c92f97f5ab (2 revisions) (#43471)

Remove implementation of SuitePlatform from the test as well. Remove use of fake cwd from SuitePlatform as it can't be properly faked.

flutter/engine@5ae09b8...7c83ea3

```
7c83ea3e85 Reland "Manual roll Dart SDK from 2d98d9e27dae to 0b07debd5862 (21 revisions) (flutter#43457)" (flutter#43472)
9ef3e8d533 Roll Skia from 5eba922297bb to 93c92f97f5ab (2 revisions) (flutter#43471)
```
@aam aam requested a review from christopherfujino as a code owner July 7, 2023 18:19
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Jul 7, 2023
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aam aam added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2023
@zanderso
Copy link
Member

zanderso commented Jul 7, 2023

Google testing has an internal error, probably because this PR contains an Engine roll. Landing this without waiting for that to clear up.

@zanderso zanderso merged commit 3b8f6c4 into flutter:master Jul 7, 2023
@aam aam deleted the roll-20230707 branch July 7, 2023 20:56
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 8, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 8, 2023
flutter/flutter@d55a7d8...65ff3cb

2023-07-08 [email protected] Roll Flutter Engine from 69eb8275ce47 to 189f823e7b41 (1 revision) (flutter/flutter#130201)
2023-07-08 [email protected] Roll Flutter Engine from d5a35b4650b1 to 69eb8275ce47 (1 revision) (flutter/flutter#130199)
2023-07-08 [email protected] Roll Flutter Engine from 9006633571bb to d5a35b4650b1 (1 revision) (flutter/flutter#130197)
2023-07-08 [email protected] Roll Flutter Engine from 4ca619166c4a to 9006633571bb (2 revisions) (flutter/flutter#130195)
2023-07-08 [email protected] Roll Flutter Engine from 13d9d84e8aba to 4ca619166c4a (2 revisions) (flutter/flutter#130191)
2023-07-08 [email protected] Roll Flutter Engine from 40a8732a5de0 to 13d9d84e8aba (2 revisions) (flutter/flutter#130189)
2023-07-08 [email protected] fix: duplicated Intellij IDE message when running flutter doctor (flutter/flutter#129030)
2023-07-08 [email protected] Remove unneeded configuration file  (flutter/flutter#130183)
2023-07-08 [email protected] Roll Flutter Engine from 893ab3bf7bb9 to 40a8732a5de0 (1 revision) (flutter/flutter#130186)
2023-07-07 [email protected] Roll Flutter Engine from b39e6fe4b3bf to 893ab3bf7bb9 (1 revision) (flutter/flutter#130180)
2023-07-07 [email protected] Roll Flutter Engine from 7c83ea3e8542 to b39e6fe4b3bf (1 revision) (flutter/flutter#130176)
2023-07-07 [email protected] Add a threshold when comparing screen order for selectables. (flutter/flutter#130043)
2023-07-07 [email protected] Upgrade framework pub dependencies, roll engine with rolled dart sdk (flutter/flutter#130163)
2023-07-07 [email protected] Revert "[a11y] CupertinoSwitch On/Off labels" (flutter/flutter#130166)
2023-07-07 [email protected] Test that inspector does not hold objects. (flutter/flutter#130102)
2023-07-07 [email protected] Fix XCode download link (flutter/flutter#129795)
2023-07-07 [email protected] Roll Packages from 9bcf4bf to b61eea1 (1 revision) (flutter/flutter#130154)
2023-07-07 [email protected] (Raw)Autocomplete: Add optional [optionsViewOpenDirection] param (flutter/flutter#129802)
2023-07-07 [email protected] Tiny one space formatting fix (flutter/flutter#130053)
2023-07-07 [email protected] Roll Flutter Engine from 8aa2e6516af1 to 5ae09b8b4fa3 (7 revisions) (flutter/flutter#130150)
2023-07-07 [email protected] Add debugging for iOS startup test flakes (flutter/flutter#130099)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos engine flutter/engine related. See also e: labels. f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants