Revert "fix a bug when android uses CupertinoPageTransitionsBuilder..… #130155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…." (flutter#130144) Reverts flutter#114303 The breaking API change in flutter#114303 broke internal tests/apps (Google internal link b/290154304) as well as external dependents: flutter#130062. Fixes flutter#130062
github-actions
bot
added
framework
CaseyHillers
approved these changes
Jul 7, 2023
Jasguerrero
added
the
autosubmit
Contributor
|
FYI I've added you to the release group. In the future, CPs for rolls can be merged with the bot approval. |
XilaiZhang
approved these changes
Jul 7, 2023
Contributor
Author
For candidate branch as well as for tip of the tree? |
Contributor
For tip of tree, go through the normal process. For candidate branches on rolls (not beta|stable releases), you can skip human review + ci |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…." (#130144)
Reverts #114303
The breaking API change in #114303 broke internal tests/apps (Google internal link b/290154304) as well as external dependents: #130062.