Fix .env regex constants #130072

PiotrFLEURY · 2023-07-06T14:18:47Z

Set .env regex list as constants.

This pull request fixes the nit related in this comment: #128668 (comment)

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

flutter-dashboard · 2023-07-06T14:18:50Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

christopherfujino · 2023-07-06T16:58:59Z

packages/flutter_tools/lib/src/runner/flutter_command.dart

I believe what Zach meant was lifting these invocations of hte RegExp constructor out of these methods and into static fields that are only allocated once. I believe the string literals are already constant.

I first tried to make RegExp objects as const but unfortunatelly the ˋRegExp` object doesn't have a const constructor.

There is already a linked issue about this topic dart-lang/sdk#27613

I can make it static final maybe ?

yes, they should be final. the point here is not about making them constant, but about avoiding a new allocation each time the methods are invoked.

I moved all the RegExp constructors. They are now build only one time.

packages/flutter_tools/lib/src/runner/flutter_command.dart

andrewkolos

LGTM

christopherfujino

LGTM

christopherfujino · 2023-07-13T20:56:42Z

manually set the google testing to green, this change shouldn't affect google targets

Set `.env` regex list as constants. This pull request fixes the nit related in this comment: flutter#128668 (comment)

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 6, 2023

PiotrFLEURY force-pushed the flutter_tools/dot_env_regex_fix branch from bbf61cb to f922e5d Compare July 6, 2023 14:36

christopherfujino reviewed Jul 6, 2023

View reviewed changes

andrewkolos self-requested a review July 6, 2023 21:26

PiotrFLEURY force-pushed the flutter_tools/dot_env_regex_fix branch from f922e5d to b0133b1 Compare July 7, 2023 06:46

andrewkolos requested changes Jul 7, 2023

View reviewed changes

packages/flutter_tools/lib/src/runner/flutter_command.dart Outdated Show resolved Hide resolved

PiotrFLEURY force-pushed the flutter_tools/dot_env_regex_fix branch from b0133b1 to a8a7bfd Compare July 10, 2023 11:27

Fix .env regex constants

3fe20e5

PiotrFLEURY force-pushed the flutter_tools/dot_env_regex_fix branch from a8a7bfd to 3fe20e5 Compare July 10, 2023 11:50

andrewkolos approved these changes Jul 10, 2023

View reviewed changes

andrewkolos requested a review from christopherfujino July 10, 2023 16:31

christopherfujino approved these changes Jul 11, 2023

View reviewed changes

christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 11, 2023

auto-submit bot merged commit 99efd1b into flutter:master Jul 13, 2023

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to b8fa92338629 (39 revisions) flutter/packages#4464

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

adffa1d

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to 5cbccc4d790a (41 revisions) flutter/packages#4465

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

08f5341

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to f5a5581fdbae (42 revisions) flutter/packages#4466

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

c1da0e2

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to b91aedb17579 (43 revisions) flutter/packages#4467

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

b770646

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to 79119dfc66c6 (44 revisions) flutter/packages#4468

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

07c3433

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to a903f1defb15 (45 revisions) flutter/packages#4470

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

094f64a

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to d5e7f407e120 (47 revisions) flutter/packages#4471

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

7a8f693

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to 934d20864d07 (48 revisions) flutter/packages#4474

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

93b4ad2

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to 56b5cc908304 (49 revisions) flutter/packages#4475

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

06447f0

engine-flutter-autoroll mentioned this pull request Jul 15, 2023

Roll Flutter from c40173f114fa to 5e5b0263c339 (65 revisions) flutter/packages#4480

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

c542d06

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

92b0875

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

91c94e0

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

ffd6e1c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

d8756da

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

f09fd3a

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

7b9de1d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

75084aa

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

8f0ddf1

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

37a97db

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

ff8abe5

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

0e530d9

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

dba1af1

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

bb1ff49

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

bc3af01

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

e088605

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

f6fe634

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

b32bdef

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

57ec507

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

eddf094

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

99efd1b Fix .env regex constants (flutter/flutter#130072)

5a2863d

LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023

Fix .env regex constants (flutter#130072)

d6ec899

Set `.env` regex list as constants. This pull request fixes the nit related in this comment: flutter#128668 (comment)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix .env regex constants #130072

Fix .env regex constants #130072

Uh oh!

PiotrFLEURY commented Jul 6, 2023

Uh oh!

flutter-dashboard bot commented Jul 6, 2023

Uh oh!

christopherfujino Jul 6, 2023

Uh oh!

PiotrFLEURY Jul 6, 2023

Uh oh!

christopherfujino Jul 6, 2023

Uh oh!

PiotrFLEURY Jul 7, 2023

Uh oh!

Uh oh!

andrewkolos left a comment

Uh oh!

christopherfujino left a comment

Uh oh!

christopherfujino commented Jul 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix .env regex constants #130072

Fix .env regex constants #130072

Uh oh!

Conversation

PiotrFLEURY commented Jul 6, 2023

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Jul 6, 2023

Uh oh!

christopherfujino Jul 6, 2023

Choose a reason for hiding this comment

Uh oh!

PiotrFLEURY Jul 6, 2023

Choose a reason for hiding this comment

Uh oh!

christopherfujino Jul 6, 2023

Choose a reason for hiding this comment

Uh oh!

PiotrFLEURY Jul 7, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

andrewkolos left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino commented Jul 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants