Skip to content

Make new issue template for 1P package #130065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jul 12, 2023
Merged

Make new issue template for 1P package #130065

auto-submit merged 1 commit into from
Jul 12, 2023

Conversation

@huycozy
Copy link
Member

@huycozy huycozy commented Jul 6, 2023

Closes #117750.

Demo

Preview screenshot

screenshot

Demo issue template: Report a bug in Flutter's first party package
Demo a filed issue: huycozy#2

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@huycozy huycozy self-assigned this Jul 6, 2023
@github-actions github-actions bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 6, 2023
stuartmorgan-g
stuartmorgan-g requested changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have some small comments, and we may have to iterate as we see how people handle the new structure in practice, but it should definitely help guide people to some common points (like upgrading packages).

@huycozy
Copy link
Member Author

huycozy commented Jul 11, 2023

Thank you for the comments. Demo of the changes I pushed:

Demo preview screenshot

screenshot (1)

Demo issue template: Report a bug in one of Flutter's first-party packages

stuartmorgan-g
stuartmorgan-g approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one last nit, thanks for doing this!

Demo issue template: Report a bug in one of Flutter's first-party packages

This was really helpful :)

@huycozy
Add 1P issue template
e0efe30 
Signed-off-by: Nguyen Huy <[email protected]>
@huycozy huycozy force-pushed the 1p-issue-template branch from 50338a2 to e0efe30 Compare July 11, 2023 16:28
@huycozy huycozy added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 12, 2023
@auto-submit auto-submit bot merged commit fd720fa into flutter:master Jul 12, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2023
@engine-flutter-autoroll
fd720fa Make new issue template for 1P package (flutter/flutter#130065)
d31f2b5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2023
@engine-flutter-autoroll
fd720fa Make new issue template for 1P package (flutter/flutter#130065)
e4c0dd1
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 12, 2023
@engine-flutter-autoroll
Roll Flutter from 3ec96a8 to 544d30d (66 revisions) (#4448)
2e46a33 
Roll Flutter from 3ec96a8 to 544d30d (66 revisions)

flutter/flutter@3ec96a8...544d30d

2023-07-12 [email protected] Roll Packages from 188a846 to 2508714 (14 revisions) (flutter/flutter#130418)
2023-07-12 [email protected] Update `RadioListTile` tests format for M2/M3 (flutter/flutter#130391)
2023-07-12 [email protected] Roll Flutter Engine from d68ea304eeda to 5c887028810d (2 revisions) (flutter/flutter#130413)
2023-07-12 [email protected] Roll Flutter Engine from c7317a58466e to d68ea304eeda (1 revision) (flutter/flutter#130410)
2023-07-12 [email protected] Roll Flutter Engine from 3dbe7dbeb5d4 to c7317a58466e (1 revision) (flutter/flutter#130402)
2023-07-12 [email protected] Roll Flutter Engine from 73093fdd77c3 to 3dbe7dbeb5d4 (1 revision) (flutter/flutter#130399)
2023-07-12 [email protected] Roll Flutter Engine from 29c5c41eeb19 to 73093fdd77c3 (2 revisions) (flutter/flutter#130398)
2023-07-12 [email protected] Roll Flutter Engine from 3482e05776a7 to 29c5c41eeb19 (1 revision) (flutter/flutter#130393)
2023-07-12 [email protected] Roll Flutter Engine from 7de68c62742d to 3482e05776a7 (2 revisions) (flutter/flutter#130390)
2023-07-12 [email protected] Make new issue template for 1P package (flutter/flutter#130065)
2023-07-12 [email protected] Roll Flutter Engine from 1b44d7ee1a60 to 7de68c62742d (4 revisions) (flutter/flutter#130384)
2023-07-12 [email protected] Roll Flutter Engine from e109a3c0c347 to 1b44d7ee1a60 (3 revisions) (flutter/flutter#130380)
2023-07-12 [email protected] Roll Flutter Engine from d00590fde18c to e109a3c0c347 (1 revision) (flutter/flutter#130371)
2023-07-12 [email protected] Roll Flutter Engine from 875d87e02276 to d00590fde18c (5 revisions) (flutter/flutter#130369)
2023-07-12 [email protected] Enable not GCed leak tracking. (flutter/flutter#130159)
2023-07-11 [email protected] Roll Flutter Engine from e2df01610fb3 to 875d87e02276 (3 revisions) (flutter/flutter#130359)
2023-07-11 [email protected] autocomplete: Remove mistaken paragraph in `onSelected` doc (flutter/flutter#130190)
2023-07-11 [email protected] Roll Flutter Engine from 59f234645dd2 to e2df01610fb3 (3 revisions) (flutter/flutter#130357)
2023-07-11 [email protected] Refactor refresh_indicator.1.dart to not use shrinkwrap (flutter/flutter#129377)
2023-07-11 [email protected] Links in `material` library docs are outdated (flutter/flutter#129891)
2023-07-11 [email protected] Roll Flutter Engine from afee1db31e5e to 59f234645dd2 (2 revisions) (flutter/flutter#130352)
2023-07-11 [email protected] Roll Flutter Engine from 75ada1bdf9fd to afee1db31e5e (1 revision) (flutter/flutter#130349)
2023-07-11 [email protected] Upgrade leak_tracker to 7.0.6. (flutter/flutter#130346)
2023-07-11 [email protected] Roll Flutter Engine from 0011db79d41f to 75ada1bdf9fd (2 revisions) (flutter/flutter#130345)
2023-07-11 [email protected] Roll pub packages (flutter/flutter#130289)
2023-07-11 [email protected] `DropdownMenu` can be expanded to its parent size (flutter/flutter#129753)
2023-07-11 [email protected] Roll Packages from 4469c5e to 188a846 (6 revisions) (flutter/flutter#130340)
2023-07-11 [email protected] Roll Flutter Engine from d75c70870f86 to 0011db79d41f (2 revisions) (flutter/flutter#130337)
2023-07-11 [email protected] Roll Flutter Engine from 5e9f0d61a42a to d75c70870f86 (1 revision) (flutter/flutter#130332)
2023-07-11 [email protected] Roll Flutter Engine from 417c50199e14 to 5e9f0d61a42a (1 revision) (flutter/flutter#130330)
2023-07-11 [email protected] Roll Flutter Engine from bfda8f173fea to 417c50199e14 (2 revisions) (flutter/flutter#130324)
2023-07-11 [email protected] Add `Badge` widget to `NavigationBar` and `NavigationRail` examples (flutter/flutter#129834)
2023-07-11 [email protected] Roll Flutter Engine from 2139c8a90822 to bfda8f173fea (2 revisions) (flutter/flutter#130321)
2023-07-11 [email protected] Update labeler for recent changes (flutter/flutter#130168)
2023-07-11 [email protected] fix: `ExpansionTileTheme.shape` assignment in `ExpansionTile` (flutter/flutter#127749)
2023-07-11 [email protected] Roll Flutter Engine from 12aa98177cf2 to 2139c8a90822 (2 revisions) (flutter/flutter#130316)
2023-07-11 [email protected] Roll Flutter Engine from 767f2fb8ab03 to 12aa98177cf2 (1 revision) (flutter/flutter#130315)
2023-07-11 [email protected] Implement preferPaintInterior correctly for _CompoundBorder (flutter/flutter#129851)
2023-07-11 [email protected] Roll Flutter Engine from 153d9e1d598a to 767f2fb8ab03 (1 revision) (flutter/flutter#130313)
2023-07-11 [email protected] Roll Flutter Engine from 2c82dd7ec54b to 153d9e1d598a (2 revisions) (flutter/flutter#130311)
2023-07-11 [email protected] Roll Flutter Engine from 312e4813a880 to 2c82dd7ec54b (1 revision) (flutter/flutter#130309)
2023-07-11 [email protected] Roll Flutter Engine from 95316fbc25a7 to 312e4813a880 (2 revisions) (flutter/flutter#130307)
2023-07-11 [email protected] Add Linux implementation of the platform view example (flutter/flutter#123731)
2023-07-11 [email protected] Roll Flutter Engine from daecd616f5a7 to 95316fbc25a7 (4 revisions) (flutter/flutter#130305)
2023-07-11 [email protected] Roll Flutter Engine from 2a0dd9d2f28e to daecd616f5a7 (3 revisions) (flutter/flutter#130298)
2023-07-10 [email protected] Roll Flutter Engine from 7d054abf842c to 2a0dd9d2f28e (4 revisions) (flutter/flutter#130296)
...
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 13, 2023
@huycozy @LouiseHsu
Make new issue template for 1P package (flutter#130065)
b7a486d 
Closes flutter#117750.

### Demo
<details>
<summary>Preview screenshot</summary>

![screenshot](https://github.com/flutter/flutter/assets/104349824/40968935-b898-4303-b3ee-08abed94f6eb)
</details>

Demo issue template: [Report a bug in Flutter's first party package](https://github.com/huycozy/flutter/issues/new?assignees=&labels=&projects=&template=9_first_party_packages.yml)
Demo a filed issue: huycozy#2
@bleroux bleroux deleted the 1p-issue-template branch March 6, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees

@huycozy huycozy

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make flutter/flutter new issue template for 1p plugins

2 participants

@huycozy @stuartmorgan-g