Skip to content

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Jul 5, 2023

This more closely matches our other conventions.

@Hixie
Copy link
Contributor Author

Hixie commented Jul 5, 2023

cc @helinanever

@github-actions github-actions bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 5, 2023
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 5, 2023
@auto-submit auto-submit bot merged commit f37a4d0 into master Jul 5, 2023
@auto-submit auto-submit bot deleted the Hixie-patch-5 branch July 5, 2023 22:34
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 6, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 6, 2023
flutter/flutter@35085c3...bc49cd1

2023-07-06 [email protected] Allow long-press gestures to continue even if buttons change. (flutter/flutter#127877)
2023-07-06 [email protected] Enable unreachable_from_main lint - it is stable now!!1 (flutter/flutter#129854)
2023-07-06 [email protected] Update labeler to new label names (flutter/flutter#130040)
2023-07-05 [email protected] MergeableMaterial: Fix adding a slice and separating it (flutter/flutter#128804)
2023-07-05 [email protected] Update infrastructure issue template for new priority scheme (flutter/flutter#129741)
2023-07-05 [email protected] Fix typo in canvas example (flutter/flutter#129879)
2023-07-05 [email protected] Reland Fix AnimatedList & AnimatedGrid doesn't apply MediaQuery padding #129556 (flutter/flutter#129860)
2023-07-05 [email protected] Change from "created via performance template" to "from: performance template" (flutter/flutter#130035)
2023-07-05 [email protected] Removes deprecated APIs from v2.6 in `binding.dart` and `widget_tester.dart` (flutter/flutter#129663)
2023-07-05 [email protected] Add new hot reload case string (flutter/flutter#130008)
2023-07-05 [email protected] Manual roll Flutter Engine from 987b621eac4e to bd2e42b203e1 (32 revisions) (flutter/flutter#130023)
2023-07-05 [email protected] Add simple unit tests for annotations.dart file (flutter/flutter#128902)
2023-07-05 [email protected] fix a bug when android uses CupertinoPageTransitionsBuilder... (flutter/flutter#114303)
2023-07-05 [email protected] Add .env file support for  option `--dart-define-from-file` (flutter/flutter#128668)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants