Skip to content

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented Jul 4, 2023

Sample code is added, documentation condensed, and links to guidelines updated.

For b/258360306

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 4, 2023
@guidezpl guidezpl requested a review from HansMuller July 4, 2023 12:03
@guidezpl guidezpl changed the title Improve documentation for [ColorSheme.fromImageProvider] Improve documentation for ColorSheme.fromImageProvider Jul 4, 2023
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 5, 2023
@auto-submit auto-submit bot merged commit 35085c3 into flutter:master Jul 5, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 5, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 5, 2023
flutter/flutter@590ef2d...35085c3

2023-07-05 [email protected] Improve documentation for `ColorSheme.fromImageProvider` (flutter/flutter#129952)
2023-07-05 [email protected] Roll Packages from a03b900 to 7042079 (2 revisions) (flutter/flutter#130013)
2023-07-04 [email protected] Cleanup: stop accepting DiagnosticsNode as input from DevTools. (flutter/flutter#129302)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@guidezpl guidezpl deleted the content-color branch July 5, 2023 17:44
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants