🚀 Expose scrollControlDisabledMaxHeightRatio to the modal bottom sheet
#129688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansMuller
added
P2
goderbauer
added
framework
Renzo-Olivares
approved these changes
Jul 20, 2023
Contributor
Renzo-Olivares
left a comment
Renzo-Olivares
left a comment
There was a problem hiding this comment.
LGTM with some small nits. Thank you for your contribution!
AlexV525
force-pushed
the
feat/expose-modal-bottom-sheet-max-height-ratio
branch
from
e72120d to
6a2aa37
Compare
Member
Author
|
@Renzo-Olivares PTAL |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
|
@AlexV525 looks like some tests are failing, can you take a look? |
Member
Author
Yeah I'll figure them out as soon as I'm available. |
Member
Author
|
@Renzo-Olivares Should be good to go. |
AlexV525
changed the title
scrollControlledMaxHeightRatio to the modal bottom sheetscrollControlDisabledMaxHeightRatio to the modal bottom sheet
Member
Author
|
@Renzo-Olivares I've updated these names to |
AlexV525
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 26, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 26, 2023
tarrinneal
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 26, 2023
flutter/flutter@9def8f6...bae1ac2 2023-07-26 [email protected] ImageDecoration.lerp (flutter/flutter#130533) 2023-07-26 [email protected] Document the Flow/Opacity/hit-test issues (flutter/flutter#131239) 2023-07-26 [email protected] Run benchmarks with `--omit-type-checks` (flutter/flutter#131102) 2023-07-26 [email protected] Roll Flutter Engine from ba83c144f84e to faf1121d010c (2 revisions) (flutter/flutter#131339) 2023-07-26 [email protected] Roll Packages from 406eac1 to a99fc87 (1 revision) (flutter/flutter#131336) 2023-07-26 [email protected] [flutter roll] Revert "Fix floating SnackBar throws when FAB is on the top" (flutter/flutter#131303) 2023-07-26 [email protected] Roll Flutter Engine from 89203002f455 to ba83c144f84e (1 revision) (flutter/flutter#131329) 2023-07-26 [email protected] Roll Flutter Engine from b3cd1c599abe to 89203002f455 (1 revision) (flutter/flutter#131323) 2023-07-26 [email protected] Roll Flutter Engine from 4bdceccff964 to b3cd1c599abe (1 revision) (flutter/flutter#131317) 2023-07-26 [email protected] Roll Flutter Engine from df12fff329a1 to 4bdceccff964 (2 revisions) (flutter/flutter#131316) 2023-07-26 [email protected] Roll Flutter Engine from 43f727e4748a to df12fff329a1 (3 revisions) (flutter/flutter#131314) 2023-07-26 [email protected] Roll Flutter Engine from 7f3b0d6b7250 to 43f727e4748a (1 revision) (flutter/flutter#131311) 2023-07-26 [email protected] Roll Flutter Engine from db711f14842b to 7f3b0d6b7250 (4 revisions) (flutter/flutter#131309) 2023-07-26 [email protected] Reorders menu item button shortcuts on Mac-like platforms (flutter/flutter#129309) 2023-07-26 [email protected] Roll Flutter Engine from 9e00c11eb519 to db711f14842b (3 revisions) (flutter/flutter#131307) 2023-07-26 [email protected] Ignore unused parameters in snippet code (flutter/flutter#131068) 2023-07-25 [email protected] Roll Flutter Engine from 3fff7316dc8d to 9e00c11eb519 (1 revision) (flutter/flutter#131299) 2023-07-25 [email protected] Add example for locking screen orientation in a letterboxing environment (flutter/flutter#131266) 2023-07-25 [email protected] Update BottomAppBar and BottomAppBarTheme tests for M3 (flutter/flutter#130983) 2023-07-25 [email protected] Roll Flutter Engine from f5fbfa859b63 to 3fff7316dc8d (4 revisions) (flutter/flutter#131286) 2023-07-25 [email protected] Add Sabin Neupane to AUTHORS (flutter/flutter#131237) 2023-07-25 [email protected] Roll Packages from 8028caf to 406eac1 (4 revisions) (flutter/flutter#131285) 2023-07-25 [email protected] Roll Flutter Engine from 0a5c6cdd5d02 to f5fbfa859b63 (8 revisions) (flutter/flutter#131283) 2023-07-25 [email protected] 🚀 Expose `scrollControlDisabledMaxHeightRatio` to the modal bottom sheet (flutter/flutter#129688) 2023-07-25 [email protected] Revert "Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog." (flutter/flutter#131278) 2023-07-25 [email protected] Roll Flutter Engine from 036c58f79307 to 0a5c6cdd5d02 (1 revision) (flutter/flutter#131256) 2023-07-25 [email protected] Fix `RawChip` doesn't use `ChipTheme.showCheckmark` value (flutter/flutter#131257) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…eet (flutter#129688) Adding the `scrollControlDisabledMaxHeightRatio` parameter for modal bottom sheet widgets, and using the default value `9.0 / 16.0` to avoid breaking. Resolves flutter#129690.
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
…eet (flutter#129688) Adding the `scrollControlDisabledMaxHeightRatio` parameter for modal bottom sheet widgets, and using the default value `9.0 / 16.0` to avoid breaking. Resolves flutter#129690.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the
scrollControlDisabledMaxHeightRatioparameter for modal bottom sheet widgets, and using the default value9.0 / 16.0to avoid breaking.Resolves #129690.
Pre-launch Checklist
///).