-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Dev, examples/api, etc updated for Material 3 by default #129683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev, examples/api, etc updated for Material 3 by default #129683
Conversation
725fba7 to
341fc34
Compare
QuncCccccc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!🤞
| return const MaterialApp( | ||
| home: HeroExample(), | ||
| return MaterialApp( | ||
| theme: ThemeData(useMaterial3: true), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double check if it is intended to set useMaterial3 to true in this example:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. All of the examples should use M3. That will happen automatically once we change the default and so changes like this can be withdrawn once the useMaterial3: true change lands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Thanks!
Roll Flutter from 96a2c05 to 51bef1b (37 revisions) flutter/flutter@96a2c05...51bef1b 2023-06-28 [email protected] Roll Flutter Engine from e8a1c23d66ba to 241ca5c1d6be (1 revision) (flutter/flutter#129725) 2023-06-28 [email protected] Update analysis, linter, and repo links in analysis options (flutter/flutter#129686) 2023-06-28 [email protected] Roll Flutter Engine from be1073aa352f to e8a1c23d66ba (1 revision) (flutter/flutter#129723) 2023-06-28 [email protected] Dev, examples/api, etc updated for Material 3 by default (flutter/flutter#129683) 2023-06-28 [email protected] Add `DatePickerTheme.inputDecorationTheme` for the DatePicker with input mode. (flutter/flutter#128950) 2023-06-28 [email protected] [framework] ensure flexible space bar fades when scrolling. (flutter/flutter#129527) 2023-06-28 [email protected] Add InputDecorator.error to allow error message customization (flutter/flutter#129275) 2023-06-28 [email protected] Roll Flutter Engine from b388e852be44 to be1073aa352f (1 revision) (flutter/flutter#129712) 2023-06-28 [email protected] Roll Flutter Engine from 17173994a8c2 to b388e852be44 (1 revision) (flutter/flutter#129708) 2023-06-28 [email protected] [flutter roll] Revert "Fix `AnimatedList` & `AnimatedGrid` doesn't apply `MediaQuery` padding" (flutter/flutter#129645) 2023-06-28 [email protected] Roll Flutter Engine from 2f4fc4872699 to 17173994a8c2 (1 revision) (flutter/flutter#129694) 2023-06-28 [email protected] Roll Flutter Engine from a6d9d12c440f to 2f4fc4872699 (1 revision) (flutter/flutter#129691) 2023-06-28 [email protected] Roll Flutter Engine from 25a5850f8b5b to a6d9d12c440f (4 revisions) (flutter/flutter#129687) 2023-06-28 [email protected] Roll Flutter Engine from 7c7c45d53bec to 25a5850f8b5b (1 revision) (flutter/flutter#129682) 2023-06-27 [email protected] Roll Flutter Engine from f320b8c36fee to 7c7c45d53bec (14 revisions) (flutter/flutter#129678) 2023-06-27 [email protected] Update labeler yaml (flutter/flutter#129676) 2023-06-27 [email protected] Revert "Fix the matcher condition where multiple matchers are found" (flutter/flutter#129675) 2023-06-27 [email protected] Revert "Labeler format to remove extra single quote" (flutter/flutter#129674) 2023-06-27 [email protected] Revert "Update labeler.yml to v5.0.0-beta.1" (flutter/flutter#129673) 2023-06-27 [email protected] Labeler format to remove extra single quote (flutter/flutter#129672) 2023-06-27 [email protected] Fix the matcher condition where multiple matchers are found (flutter/flutter#129670) 2023-06-27 [email protected] Automatically migrate ClipboardData.text to non-null (flutter/flutter#129567) 2023-06-27 [email protected] Remove Editable.onCaretChanged callback (flutter/flutter#109114) 2023-06-27 [email protected] Reland "Fix issue where DevTools would not be immediately available when using --start-paused (#126698)" (flutter/flutter#129368) 2023-06-27 [email protected] Update Xcode to 14.3.1 (flutter/flutter#129024) 2023-06-27 [email protected] Adds `dart_fix` support to `integration_test` (flutter/flutter#129579) 2023-06-27 [email protected] Update labeler.yml to v5.0.0-beta.1 (flutter/flutter#129617) 2023-06-27 [email protected] iOS TextSelectionToolbar fidelity (flutter/flutter#127757) 2023-06-27 [email protected] Make a paragraph test involving Chinese characters work with inconsistent host system fonts (flutter/flutter#129628) 2023-06-27 [email protected] Roll Packages from 6b70804 to f89ce02 (7 revisions) (flutter/flutter#129630) 2023-06-27 [email protected] Roll Flutter Engine from 715eff211a42 to f320b8c36fee (6 revisions) (flutter/flutter#129599) 2023-06-27 [email protected] Fix chinese text is not selected by long press (flutter/flutter#129320) 2023-06-26 [email protected] Roll Flutter Engine from 0da06de991a9 to 715eff211a42 (4 revisions) (flutter/flutter#129593) 2023-06-26 [email protected] Fix syntax error in no-response (flutter/flutter#129588) 2023-06-26 [email protected] Roll Flutter Engine from f2d70cc809cd to 0da06de991a9 (3 revisions) (flutter/flutter#129582) 2023-06-26 [email protected] Updated chip_test.dart tests for M3 (flutter/flutter#129570) 2023-06-26 [email protected] Roll Flutter Engine from 4032a9bc964e to f2d70cc809cd (4 revisions) (flutter/flutter#129574) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...
Updated tests in dev, examples/api, and tests/widgets to ensure that they continue to pass when the default for
ThemeData.useMaterial3is changed to true.This is the final set of changes required for #127064.
Based on #127501, which was presubmit tested with
useMaterial3: true.