Skip to content

Conversation

@eyebrowsoffire
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire commented Jun 27, 2023

This enables benchmarks for the Skwasm renderer, compiled with dart2wasm.

Platform views aren't supported in Skwasm yet, so we are skipping those benchmarks for now.

@eyebrowsoffire eyebrowsoffire marked this pull request as ready for review June 28, 2023 17:31
@eyebrowsoffire eyebrowsoffire requested a review from yjbanov June 28, 2023 18:50
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 28, 2023
@eyebrowsoffire eyebrowsoffire merged commit 1b887c7 into flutter:master Jun 29, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2023
camsim99 added a commit to flutter/packages that referenced this pull request Jun 30, 2023
flutter/flutter@51bef1b...ff838bc

2023-06-29 [email protected] Add locale-specific
DateTime formatting syntax (flutter/flutter#129573)
2023-06-29 [email protected] Update `RadioListTile` tests to M3
(flutter/flutter#129718)
2023-06-29 [email protected] Roll Flutter Engine from
7fd0e9522ea1 to eabb22900b44 (1 revision) (flutter/flutter#129754)
2023-06-29 [email protected] Roll Flutter Engine from
d5c25ead07e9 to 7fd0e9522ea1 (2 revisions) (flutter/flutter#129752)
2023-06-29 [email protected] Fix typos in ListTile examples.
(flutter/flutter#129606)
2023-06-29 [email protected] Roll Flutter Engine from
4e49b9deb72d to d5c25ead07e9 (7 revisions) (flutter/flutter#129750)
2023-06-29 [email protected] Roll Flutter Engine from
241ca5c1d6be to 4e49b9deb72d (1 revision) (flutter/flutter#129730)
2023-06-29 [email protected] Skwasm benchmarks.
(flutter/flutter#129681)
2023-06-28 [email protected] RTL InputDecoration fix
(flutter/flutter#129661)
2023-06-28 [email protected] mark autoroller flaky
(flutter/flutter#129745)
2023-06-28 [email protected] Roll pub packages
(flutter/flutter#129380)
2023-06-28 [email protected] Removes
deprecated APIs from AnimationBuilder (flutter/flutter#129657)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
[email protected],[email protected],[email protected] on
the revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

---------

Co-authored-by: Camille Simon <[email protected]>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@eyebrowsoffire eyebrowsoffire deleted the skwasm_benchmarks branch December 12, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants