-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Fix typos in ListTile examples. #129606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos in ListTile examples. #129606
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
TahaTesser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
This will need a test-exemption from @Hixie |
|
test-exempt: code refactor with no semantic change |
|
auto label is removed for flutter/flutter, pr: 129606, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.
|
|
Can someone else approve this PR? Thanks! |
|
LGTM |
flutter/flutter@51bef1b...ff838bc 2023-06-29 [email protected] Add locale-specific DateTime formatting syntax (flutter/flutter#129573) 2023-06-29 [email protected] Update `RadioListTile` tests to M3 (flutter/flutter#129718) 2023-06-29 [email protected] Roll Flutter Engine from 7fd0e9522ea1 to eabb22900b44 (1 revision) (flutter/flutter#129754) 2023-06-29 [email protected] Roll Flutter Engine from d5c25ead07e9 to 7fd0e9522ea1 (2 revisions) (flutter/flutter#129752) 2023-06-29 [email protected] Fix typos in ListTile examples. (flutter/flutter#129606) 2023-06-29 [email protected] Roll Flutter Engine from 4e49b9deb72d to d5c25ead07e9 (7 revisions) (flutter/flutter#129750) 2023-06-29 [email protected] Roll Flutter Engine from 241ca5c1d6be to 4e49b9deb72d (1 revision) (flutter/flutter#129730) 2023-06-29 [email protected] Skwasm benchmarks. (flutter/flutter#129681) 2023-06-28 [email protected] RTL InputDecoration fix (flutter/flutter#129661) 2023-06-28 [email protected] mark autoroller flaky (flutter/flutter#129745) 2023-06-28 [email protected] Roll pub packages (flutter/flutter#129380) 2023-06-28 [email protected] Removes deprecated APIs from AnimationBuilder (flutter/flutter#129657) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md --------- Co-authored-by: Camille Simon <[email protected]>
Fix typos.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.