Adds dart_fix support to integration_test
#129579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds fix for `IntegrationTestWidgetsFlutterBinding.runTest(timeout)` to support first round of deprecations for `flutter_test`
github-actions
bot
added
a: tests
pdblasi-google
commented
Jun 26, 2023
.../fix_data/fix_integration_test/fix_binding/fix_integration_test_widgets_flutter_binding.yaml
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Jun 26, 2023
loic-sharma
reviewed
Jun 26, 2023
| ## Directory contents | ||
|
|
||
| The `.yaml` files in these directories are used to | ||
| define the [`dart fix` framework](https://dart.dev/tools/dart-fix) refactorings |
Member
There was a problem hiding this comment.
I think framework here was indirectly referring to the flutter package, perhaps consider removing that from this line?
Suggested change
| define the [`dart fix` framework](https://dart.dev/tools/dart-fix) refactorings | |
| define the [`dart fix`](https://dart.dev/tools/dart-fix) refactorings |
Contributor
Author
There was a problem hiding this comment.
Hmmm. Now that you point it out, that wording is pretty awkward in all of the fix_data/README.md files... Think it'd be worth it to remove the "framework" part for all of them?
loic-sharma
reviewed
Jun 26, 2023
Comment on lines
+33
to
+36
| The tests in this directory are also invoked from external | ||
| repositories. Specifically, the CI system for the dart-lang/sdk repo | ||
| runs these tests in order to ensure that changes to the dart fix file | ||
| format do not break Flutter. |
Member
There was a problem hiding this comment.
Is this true for the integration test ones as well?
Contributor
Author
There was a problem hiding this comment.
Not yet, but I did write up dart #52795 to start that discussion with the dart team. We had the same question and resolution when we added dart fix to flutter_test as well.
loic-sharma
reviewed
Jun 26, 2023
.../fix_data/fix_integration_test/fix_binding/fix_integration_test_widgets_flutter_binding.yaml
Outdated
Show resolved
Hide resolved
loic-sharma
approved these changes
Jun 26, 2023
Member
loic-sharma
left a comment
loic-sharma
left a comment
There was a problem hiding this comment.
Dart fix looks good to me, but please get another approval from someone who has added dart fix support to another project before :)
goderbauer
approved these changes
Jun 26, 2023
| @@ -0,0 +1,45 @@ | |||
| ## Directory contents | |||
Member
There was a problem hiding this comment.
This readme (and the template.yaml) should be the same here, for the flutter framework, and for flutter_test, right? I wonder, if it would make sense to maintain it only once (maybe in the framework) and have the other packages just link to that in their readme? There's not much value in repeating all this information and the policies should be consistent between packages, anyways...
Contributor
Author
There was a problem hiding this comment.
There were a few differences between the main flutter/flutter README and the flutter_test one. Primarily in regards to examples, and a minor difference in verbiage about libraries since flutter/flutter actually contains multiple libraries while these test ones do not.
The integration_test README is exactly the same as the flutter_test one though, besides renaming and referencing their respective packages.
pdblasi-google
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 27, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 28, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 28, 2023
Roll Flutter from 96a2c05 to 51bef1b (37 revisions) flutter/flutter@96a2c05...51bef1b 2023-06-28 [email protected] Roll Flutter Engine from e8a1c23d66ba to 241ca5c1d6be (1 revision) (flutter/flutter#129725) 2023-06-28 [email protected] Update analysis, linter, and repo links in analysis options (flutter/flutter#129686) 2023-06-28 [email protected] Roll Flutter Engine from be1073aa352f to e8a1c23d66ba (1 revision) (flutter/flutter#129723) 2023-06-28 [email protected] Dev, examples/api, etc updated for Material 3 by default (flutter/flutter#129683) 2023-06-28 [email protected] Add `DatePickerTheme.inputDecorationTheme` for the DatePicker with input mode. (flutter/flutter#128950) 2023-06-28 [email protected] [framework] ensure flexible space bar fades when scrolling. (flutter/flutter#129527) 2023-06-28 [email protected] Add InputDecorator.error to allow error message customization (flutter/flutter#129275) 2023-06-28 [email protected] Roll Flutter Engine from b388e852be44 to be1073aa352f (1 revision) (flutter/flutter#129712) 2023-06-28 [email protected] Roll Flutter Engine from 17173994a8c2 to b388e852be44 (1 revision) (flutter/flutter#129708) 2023-06-28 [email protected] [flutter roll] Revert "Fix `AnimatedList` & `AnimatedGrid` doesn't apply `MediaQuery` padding" (flutter/flutter#129645) 2023-06-28 [email protected] Roll Flutter Engine from 2f4fc4872699 to 17173994a8c2 (1 revision) (flutter/flutter#129694) 2023-06-28 [email protected] Roll Flutter Engine from a6d9d12c440f to 2f4fc4872699 (1 revision) (flutter/flutter#129691) 2023-06-28 [email protected] Roll Flutter Engine from 25a5850f8b5b to a6d9d12c440f (4 revisions) (flutter/flutter#129687) 2023-06-28 [email protected] Roll Flutter Engine from 7c7c45d53bec to 25a5850f8b5b (1 revision) (flutter/flutter#129682) 2023-06-27 [email protected] Roll Flutter Engine from f320b8c36fee to 7c7c45d53bec (14 revisions) (flutter/flutter#129678) 2023-06-27 [email protected] Update labeler yaml (flutter/flutter#129676) 2023-06-27 [email protected] Revert "Fix the matcher condition where multiple matchers are found" (flutter/flutter#129675) 2023-06-27 [email protected] Revert "Labeler format to remove extra single quote" (flutter/flutter#129674) 2023-06-27 [email protected] Revert "Update labeler.yml to v5.0.0-beta.1" (flutter/flutter#129673) 2023-06-27 [email protected] Labeler format to remove extra single quote (flutter/flutter#129672) 2023-06-27 [email protected] Fix the matcher condition where multiple matchers are found (flutter/flutter#129670) 2023-06-27 [email protected] Automatically migrate ClipboardData.text to non-null (flutter/flutter#129567) 2023-06-27 [email protected] Remove Editable.onCaretChanged callback (flutter/flutter#109114) 2023-06-27 [email protected] Reland "Fix issue where DevTools would not be immediately available when using --start-paused (#126698)" (flutter/flutter#129368) 2023-06-27 [email protected] Update Xcode to 14.3.1 (flutter/flutter#129024) 2023-06-27 [email protected] Adds `dart_fix` support to `integration_test` (flutter/flutter#129579) 2023-06-27 [email protected] Update labeler.yml to v5.0.0-beta.1 (flutter/flutter#129617) 2023-06-27 [email protected] iOS TextSelectionToolbar fidelity (flutter/flutter#127757) 2023-06-27 [email protected] Make a paragraph test involving Chinese characters work with inconsistent host system fonts (flutter/flutter#129628) 2023-06-27 [email protected] Roll Packages from 6b70804 to f89ce02 (7 revisions) (flutter/flutter#129630) 2023-06-27 [email protected] Roll Flutter Engine from 715eff211a42 to f320b8c36fee (6 revisions) (flutter/flutter#129599) 2023-06-27 [email protected] Fix chinese text is not selected by long press (flutter/flutter#129320) 2023-06-26 [email protected] Roll Flutter Engine from 0da06de991a9 to 715eff211a42 (4 revisions) (flutter/flutter#129593) 2023-06-26 [email protected] Fix syntax error in no-response (flutter/flutter#129588) 2023-06-26 [email protected] Roll Flutter Engine from f2d70cc809cd to 0da06de991a9 (3 revisions) (flutter/flutter#129582) 2023-06-26 [email protected] Updated chip_test.dart tests for M3 (flutter/flutter#129570) 2023-06-26 [email protected] Roll Flutter Engine from 4032a9bc964e to f2d70cc809cd (4 revisions) (flutter/flutter#129574) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntegrationTestWidgetsFlutterBinding.runTest(timeout)to support first round of deprecations forflutter_testResolves #124346
Pre-launch Checklist
///).