Skip to content

[CP] Fix TextField not responding to taps when wrapped in a GestureDetector #129576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jul 10, 2023
Merged

[CP] Fix TextField not responding to taps when wrapped in a GestureDetector #129576

auto-submit merged 1 commit into from
Jul 10, 2023

Conversation

@Renzo-Olivares
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares commented Jun 26, 2023 •
edited
Loading

Cherry pick for issue #129161 / PR #129312

CP Issue: #129577

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@Renzo-Olivares
_TapStatusTrackerMixin should wait until the next `PointerDownEvent…
164eb2e 
…` before resetting its state when the tap timer has elapsed (flutter#129312)

`_TapStatusTrackerMixin` used by `BaseTapAndDragGestureRecognizer` should wait until the next tap down before resetting its state when the `_consecutiveTapTimer` times out. This is because `BaseTapAndDragGestureRecognizer` may not have fired its tap down/tap up event before the state has been reset preventing it from firing the tap down/tap up callbacks at all because `currentDown` and `currentUp` are reset to `null`.

Fixes flutter#129161
@Renzo-Olivares Renzo-Olivares mentioned this pull request Jun 26, 2023
Closed
@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 10, 2023
@auto-submit auto-submit bot merged commit 9a3a31d into flutter:flutter-3.10-candidate.1 Jul 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 13, 2023
@engine-flutter-autoroll
9a3a31d8d [CP] Fix TextField not responding to taps when wrapped in a…
f9f54b3 
… GestureDetector (flutter/flutter#129576)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@CaseyHillers CaseyHillers CaseyHillers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Renzo-Olivares @CaseyHillers