Skip to content

Add onSubmitted property to SearchBar #129365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Jun 22, 2023
Merged

Add onSubmitted property to SearchBar #129365

auto-submit merged 3 commits into from
Jun 22, 2023

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Jun 22, 2023

Fixes #126551

This PR is to add onSubmitted property to SearchBar.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 22, 2023
@QuncCccccc QuncCccccc marked this pull request as ready for review June 22, 2023 20:31
@QuncCccccc QuncCccccc requested a review from HansMuller June 22, 2023 20:32
HansMuller
HansMuller approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 22, 2023
@auto-submit auto-submit bot merged commit 5140b0f into master Jun 22, 2023
@auto-submit auto-submit bot deleted the add_on_submitted_to_search_bar branch June 22, 2023 21:19
@QuncCccccc QuncCccccc mentioned this pull request Jun 22, 2023
Closed
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
5140b0f Add onSubmitted property to SearchBar (flutter/flutter#12…
d67c1d0 
…9365)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
5140b0f Add onSubmitted property to SearchBar (flutter/flutter#12…
f6b7c37 
…9365)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
5140b0f Add onSubmitted property to SearchBar (flutter/flutter#12…
c36c1df 
…9365)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
5140b0f Add onSubmitted property to SearchBar (flutter/flutter#12…
be6d98d 
…9365)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
5140b0f Add onSubmitted property to SearchBar (flutter/flutter#12…
123fd9b 
…9365)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
5140b0f Add onSubmitted property to SearchBar (flutter/flutter#12…
e6a8f13 
…9365)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
5140b0f Add onSubmitted property to SearchBar (flutter/flutter#12…
bd7129f 
…9365)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
5140b0f Add onSubmitted property to SearchBar (flutter/flutter#12…
0da6115 
…9365)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
5140b0f Add onSubmitted property to SearchBar (flutter/flutter#12…
5db6639 
…9365)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
5140b0f Add onSubmitted property to SearchBar (flutter/flutter#12…
17e3021 
…9365)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
5140b0f Add onSubmitted property to SearchBar (flutter/flutter#12…
11af3da 
…9365)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
5140b0f Add onSubmitted property to SearchBar (flutter/flutter#12…
ef8459f 
…9365)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
5140b0f Add onSubmitted property to SearchBar (flutter/flutter#12…
8e9d26c 
…9365)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
5140b0f Add onSubmitted property to SearchBar (flutter/flutter#12…
d2b0091 
…9365)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
5140b0f Add onSubmitted property to SearchBar (flutter/flutter#12…
cff3218 
…9365)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
5140b0f Add onSubmitted property to SearchBar (flutter/flutter#12…
d1ec98a 
…9365)
@HansMuller HansMuller mentioned this pull request Jun 30, 2023
Closed
@PsyOhm23
Copy link

PsyOhm23 commented Jul 13, 2023

Hi, I don't know if I can report a potential associated issue here but the SearchAnchor.bar don't have the onChanged or the recently added onSubmitted property ?
Thanks

@PsyOhm23
Copy link

PsyOhm23 commented Jul 16, 2023

@QuncCccccc any advice ?

@PsyOhm23 PsyOhm23 mentioned this pull request Jul 16, 2023
Closed
2 tasks
@QuncCccccc
Copy link
Contributor Author

QuncCccccc commented Jul 17, 2023

@QuncCccccc any advice ?

Creating an issue sounds good to me! Will add this to SearchAnchor.bar soon. Thanks:)

@PsyOhm23
Copy link

PsyOhm23 commented Jul 17, 2023

Thanks for your reply :) I've created this issue #130687 ;)

@miquelbeltran miquelbeltran mentioned this pull request Jul 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
5140b0f Add onSubmitted property to SearchBar (flutter/flutter#12…
f8d9470 
…9365)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5140b0f Add onSubmitted property to SearchBar (flutter/flutter#12…
e6f69ff 
…9365)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5140b0f Add onSubmitted property to SearchBar (flutter/flutter#12…
5e7a832 
…9365)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5140b0f Add onSubmitted property to SearchBar (flutter/flutter#12…
ef25e34 
…9365)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add onSubmitted to SearchBar

3 participants

@QuncCccccc @PsyOhm23 @HansMuller