Skip to content

[flutter_tools] delete flutter format command #129360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jun 22, 2023
Merged

[flutter_tools] delete flutter format command #129360

auto-submit merged 1 commit into from
Jun 22, 2023

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Jun 22, 2023 •
edited
Loading

On the current stable branch (3.10.x), flutter format no longer works, and gives an error. This change just deletes the code.

Fixes #115809

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 22, 2023
eliasyishak
eliasyishak approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@eliasyishak eliasyishak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

jonahwilliams
jonahwilliams approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 22, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 22, 2023

auto label is removed for flutter/flutter, pr: 129360, Mergeability of pull request flutter/flutter/129360 could not be determined at time of merge..

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 22, 2023
@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 22, 2023
@auto-submit auto-submit bot merged commit 6f3b078 into flutter:master Jun 22, 2023
@christopherfujino christopherfujino deleted the delete-format-command branch June 22, 2023 21:29
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
6f3b078 [flutter_tools] delete flutter format command (flutter/flutte…
e3e9713 
…r#129360)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
6f3b078 [flutter_tools] delete flutter format command (flutter/flutte…
e51d6cf 
…r#129360)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
6f3b078 [flutter_tools] delete flutter format command (flutter/flutte…
663401d 
…r#129360)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
6f3b078 [flutter_tools] delete flutter format command (flutter/flutte…
81fe31a 
…r#129360)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
6f3b078 [flutter_tools] delete flutter format command (flutter/flutte…
4afd7d3 
…r#129360)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
6f3b078 [flutter_tools] delete flutter format command (flutter/flutte…
441d6bc 
…r#129360)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
6f3b078 [flutter_tools] delete flutter format command (flutter/flutte…
d26a6d2 
…r#129360)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
6f3b078 [flutter_tools] delete flutter format command (flutter/flutte…
d874d81 
…r#129360)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
6f3b078 [flutter_tools] delete flutter format command (flutter/flutte…
1ca36e9 
…r#129360)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
6f3b078 [flutter_tools] delete flutter format command (flutter/flutte…
685e350 
…r#129360)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
6f3b078 [flutter_tools] delete flutter format command (flutter/flutte…
18a1e81 
…r#129360)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
6f3b078 [flutter_tools] delete flutter format command (flutter/flutte…
c1e6244 
…r#129360)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
6f3b078 [flutter_tools] delete flutter format command (flutter/flutte…
47799b2 
…r#129360)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
6f3b078 [flutter_tools] delete flutter format command (flutter/flutte…
04cdd41 
…r#129360)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
6f3b078 [flutter_tools] delete flutter format command (flutter/flutte…
04dc8df 
…r#129360)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
6f3b078 [flutter_tools] delete flutter format command (flutter/flutte…
2de6c4d 
…r#129360)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
6f3b078 [flutter_tools] delete flutter format command (flutter/flutte…
a987f92 
…r#129360)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
6f3b078 [flutter_tools] delete flutter format command (flutter/flutte…
270678e 
…r#129360)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
6f3b078 [flutter_tools] delete flutter format command (flutter/flutte…
421a57d 
…r#129360)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
6f3b078 [flutter_tools] delete flutter format command (flutter/flutte…
7ea16e4 
…r#129360)
@parlough parlough mentioned this pull request Sep 29, 2023
Merged
IanVS added a commit to DefinedNet/mobile_nebula that referenced this pull request Sep 27, 2024
@IanVS
Fix flutter format command
4403fef 
It was removed in 3.12: flutter/flutter#129360
@IanVS IanVS mentioned this pull request Sep 27, 2024
Merged
IanVS added a commit to DefinedNet/mobile_nebula that referenced this pull request Oct 7, 2024
@IanVS
Flutter format is removed, now dart format (#168)
cc0ee7c 
It was removed in 3.12: flutter/flutter#129360

This updates the README and our CI job.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@eliasyishak eliasyishak eliasyishak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[flutter_tools] Deprecate flutter format sub-command in favor of dart format

3 participants

@christopherfujino @jonahwilliams @eliasyishak