Cleanup: stop accepting DiagnosticsNode as input from DevTools. #129302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
framework
polina-c
changed the title
jacob314
reviewed
Jun 21, 2023
Contributor
Author
|
Tested Devtools > Inspector with this version of flutter: Screen.Recording.2023-06-21.at.3.45.43.PM.mov |
github-actions
bot
removed
the
framework
polina-c
changed the title
github-actions
bot
added
the
framework
polina-c
added
the
autosubmit
This was referenced Jun 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 5, 2023
2 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 5, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 5, 2023
flutter/flutter@590ef2d...35085c3 2023-07-05 [email protected] Improve documentation for `ColorSheme.fromImageProvider` (flutter/flutter#129952) 2023-07-05 [email protected] Roll Packages from a03b900 to 7042079 (2 revisions) (flutter/flutter#130013) 2023-07-04 [email protected] Cleanup: stop accepting DiagnosticsNode as input from DevTools. (flutter/flutter#129302) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
polina-c
added
the
a: leak tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merge should wait for DevTools 2.25.0