Skip to content

Revert "Remove AbstractNode from RenderObject and deprecate it" #129125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CaseyHillers wants to merge 1 commit into from
Closed

Revert "Remove AbstractNode from RenderObject and deprecate it" #129125

CaseyHillers wants to merge 1 commit into from

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Jun 19, 2023

Reverts #128973

This has broken a large number of goldens and tests for Google.

See b/287958958

@CaseyHillers CaseyHillers requested a review from goderbauer June 19, 2023 14:37
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Jun 19, 2023
zanderso
zanderso approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@CaseyHillers CaseyHillers mentioned this pull request Jun 19, 2023
Closed
@CaseyHillers
Copy link
Contributor Author

CaseyHillers commented Jun 19, 2023

Further bisection resulted in it being b/286999102

@guidezpl guidezpl deleted the revert-128973-removeAbstractFromRender branch April 18, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

@jason-simmons jason-simmons jason-simmons approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CaseyHillers @zanderso @jason-simmons