Skip to content

Accept Diagnosticable as input in inspector API. #128962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 21 commits into from
Jun 16, 2023
Merged

Accept Diagnosticable as input in inspector API. #128962

polina-c merged 21 commits into from
Jun 16, 2023

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Jun 15, 2023 •
edited
Loading

Bigger issue: flutter/devtools#3951

Updated APIs:
getSelectedSummaryWidget - replace with null on devtools side and remove on flutter side
getSelectedWidget - replace with null on devtools side and remove on flutter side
getChildrenSummaryTree
getChildrenDetailsSubtree
getDetailsSubtree
getLayoutExplorerNode

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Jun 15, 2023
@polina-c polina-c changed the title Accept Diagnosticable as input in API. Accept Diagnosticable as input in inspector API. Jun 15, 2023
@polina-c polina-c mentioned this pull request Jun 15, 2023
Merged
@polina-c polina-c mentioned this pull request Jun 16, 2023
Closed
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Jun 16, 2023
@github-actions github-actions bot removed the engine flutter/engine related. See also e: labels. label Jun 16, 2023
@polina-c polina-c marked this pull request as ready for review June 16, 2023 00:56
jacob314
jacob314 approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 16, 2023
@polina-c polina-c merged commit 7214cb2 into flutter:master Jun 16, 2023
@polina-c polina-c deleted the remaining branch June 16, 2023 17:45
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2023
@engine-flutter-autoroll
7214cb2 Accept Diagnosticable as input in inspector API. (flutter/flu…
72c28f1 
…tter#128962)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 17, 2023
@engine-flutter-autoroll
7214cb2 Accept Diagnosticable as input in inspector API. (flutter/flu…
b8e4463 
…tter#128962)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 18, 2023
@engine-flutter-autoroll
7214cb2 Accept Diagnosticable as input in inspector API. (flutter/flu…
0611737 
…tter#128962)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2023
@engine-flutter-autoroll
7214cb2 Accept Diagnosticable as input in inspector API. (flutter/flu…
fa492f1 
…tter#128962)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 19, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 19, 2023
@engine-flutter-autoroll
7214cb2 Accept Diagnosticable as input in inspector API. (flutter/flu…
8862de8 
…tter#128962)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 20, 2023
@engine-flutter-autoroll
7214cb2 Accept Diagnosticable as input in inspector API. (flutter/flu…
a840bc6 
…tter#128962)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 20, 2023
@engine-flutter-autoroll
7214cb2 Accept Diagnosticable as input in inspector API. (flutter/flu…
f4878a1 
…tter#128962)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 20, 2023
@engine-flutter-autoroll
7214cb2 Accept Diagnosticable as input in inspector API. (flutter/flu…
d4a3d72 
…tter#128962)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 21, 2023
@engine-flutter-autoroll
7214cb2 Accept Diagnosticable as input in inspector API. (flutter/flu…
5e7079e 
…tter#128962)
This was referenced Jul 4, 2023
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
7214cb2 Accept Diagnosticable as input in inspector API. (flutter/flu…
c9234a7 
…tter#128962)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
7214cb2 Accept Diagnosticable as input in inspector API. (flutter/flu…
4e6e9bd 
…tter#128962)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
7214cb2 Accept Diagnosticable as input in inspector API. (flutter/flu…
9ec02b0 
…tter#128962)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
7214cb2 Accept Diagnosticable as input in inspector API. (flutter/flu…
0a540d9 
…tter#128962)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacob314 jacob314 jacob314 approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@polina-c @jacob314