flutter update-packages --cherry-pick-package #128917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
Hixie
force-pushed
the
force_upgrade_version
branch
3 times, most recently
from
2a0fcad to
41660ad
Compare
Contributor
Author
|
I've no idea how to reliably test this. I'll add some tests for some of the periphery, but the core is fundamentally so dependent on the environment that making a real test seems like it'd be super flaky. |
Hixie
force-pushed
the
force_upgrade_version
branch
from
41660ad to
122c2d3
Compare
Contributor
There was a problem hiding this comment.
would we need this? I would prefer we only support cherrypicking if you know the exact version. Consider package:foo with the following versions available:
v1.0 - the current version in the latest Flutter stable
v2.0 - the latest version available in pub with breaking changes
v1.0+1 - a special hotfix release to fix a bug in the Flutter stable
If a user simply did flutter update-packages --cherry-pick-package=foo they may upgrade it to 2.0, rather than 1.0+1.
Contributor
|
Two analysis failures: |
christopherfujino
approved these changes
Jun 15, 2023
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
Suggestion that we require --cherry-pick-version if --cherry-pick-package is provided, otherwise LGTM
Hixie
force-pushed
the
force_upgrade_version
branch
from
122c2d3 to
86de49f
Compare
Contributor
Author
|
I found a way to test this better than I expected. Still not a really full test, though. |
Hixie
force-pushed
the
force_upgrade_version
branch
from
86de49f to
a0271d5
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 16, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 16, 2023
flutter/flutter@b0188cd...fc8856e 2023-06-16 [email protected] [web] Don't crash on `const HtmlElementView()` (flutter/flutter#128965) 2023-06-16 [email protected] Roll Packages from 0507297 to f9314a3 (3 revisions) (flutter/flutter#128878) 2023-06-16 [email protected] Update getProperties to handle Diagnosticable as input. (flutter/flutter#128897) 2023-06-15 [email protected] Roll Flutter Engine from 48e0b4e66422 to fb5fed432e59 (1 revision) (flutter/flutter#128967) 2023-06-15 [email protected] Fix dart pub cache clean command on pub.dart (flutter/flutter#128171) 2023-06-15 [email protected] [flutter_tools] Migrate more integration tests to process result matcher (flutter/flutter#128737) 2023-06-15 [email protected] [flutter_tools] refactor license collector (flutter/flutter#128748) 2023-06-15 [email protected] Set Semantics.button to true for date widget (flutter/flutter#128824) 2023-06-15 [email protected] Update golden tests (flutter/flutter#128914) 2023-06-15 [email protected] Roll Flutter Engine from 9934c0de738c to 48e0b4e66422 (26 revisions) (flutter/flutter#128959) 2023-06-15 [email protected] flutter update-packages --cherry-pick-package (flutter/flutter#128917) 2023-06-15 [email protected] add .pub-cache back to .gitignore (flutter/flutter#128894) 2023-06-15 [email protected] Roll Flutter Engine from 2d8d5ecfe4a8 to 9934c0de738c (2 revisions) (flutter/flutter#128849) 2023-06-15 [email protected] flutter update-packages --force-upgrade (flutter/flutter#128908) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101525