Skip to content

Update golden tests #128914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QuncCccccc merged 3 commits into from
Jun 15, 2023
Merged

Update golden tests #128914

QuncCccccc merged 3 commits into from
Jun 15, 2023

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Jun 14, 2023 •
edited
Loading

This PR is to update the rest of golden tests.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 14, 2023
@QuncCccccc QuncCccccc force-pushed the update_rest_golden_tests branch from 1fd12d5 to 99d7462 Compare June 14, 2023 23:16
@QuncCccccc QuncCccccc marked this pull request as ready for review June 14, 2023 23:34
@HansMuller HansMuller mentioned this pull request Jun 14, 2023
Closed
25 tasks
@QuncCccccc QuncCccccc force-pushed the update_rest_golden_tests branch 2 times, most recently from 2e6223a to df9f7e3 Compare June 15, 2023 00:49
@github-actions github-actions bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. and removed f: material design flutter/packages/flutter/material repository. labels Jun 15, 2023
@QuncCccccc QuncCccccc force-pushed the update_rest_golden_tests branch from 458a155 to 203522c Compare June 15, 2023 01:56
@github-actions github-actions bot removed f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. labels Jun 15, 2023
@QuncCccccc QuncCccccc requested a review from HansMuller June 15, 2023 02:00
@QuncCccccc QuncCccccc force-pushed the update_rest_golden_tests branch from 203522c to 1811f5c Compare June 15, 2023 02:02
@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 15, 2023
@QuncCccccc QuncCccccc force-pushed the update_rest_golden_tests branch from aafaa6a to 1cb5ef1 Compare June 15, 2023 16:44
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 15, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 15, 2023

auto label is removed for flutter/flutter, pr: 128914, due to - The status or check suite docs-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite customer_testing-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-libraries-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-widgets-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-misc-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 15, 2023
@QuncCccccc QuncCccccc merged commit c3b2175 into master Jun 15, 2023
@QuncCccccc QuncCccccc deleted the update_rest_golden_tests branch June 15, 2023 20:09
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 16, 2023
@engine-flutter-autoroll
c3b2175 Update golden tests (flutter/flutter#128914)
6644672
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 16, 2023
@engine-flutter-autoroll
Roll Flutter from b0188cd to fc8856e (14 revisions) (#4231)
08ab0af 
flutter/flutter@b0188cd...fc8856e

2023-06-16 [email protected] [web] Don't crash on `const HtmlElementView()` (flutter/flutter#128965)
2023-06-16 [email protected] Roll Packages from 0507297 to f9314a3 (3 revisions) (flutter/flutter#128878)
2023-06-16 [email protected] Update getProperties to handle Diagnosticable as input. (flutter/flutter#128897)
2023-06-15 [email protected] Roll Flutter Engine from 48e0b4e66422 to fb5fed432e59 (1 revision) (flutter/flutter#128967)
2023-06-15 [email protected] Fix dart pub cache clean command on pub.dart (flutter/flutter#128171)
2023-06-15 [email protected] [flutter_tools] Migrate more integration tests to process result matcher (flutter/flutter#128737)
2023-06-15 [email protected] [flutter_tools] refactor license collector (flutter/flutter#128748)
2023-06-15 [email protected] Set Semantics.button to true for date widget (flutter/flutter#128824)
2023-06-15 [email protected] Update golden tests (flutter/flutter#128914)
2023-06-15 [email protected] Roll Flutter Engine from 9934c0de738c to 48e0b4e66422 (26 revisions) (flutter/flutter#128959)
2023-06-15 [email protected] flutter update-packages --cherry-pick-package (flutter/flutter#128917)
2023-06-15 [email protected] add .pub-cache back to .gitignore (flutter/flutter#128894)
2023-06-15 [email protected] Roll Flutter Engine from 2d8d5ecfe4a8 to 9934c0de738c (2 revisions) (flutter/flutter#128849)
2023-06-15 [email protected] flutter update-packages --force-upgrade (flutter/flutter#128908)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@HansMuller HansMuller mentioned this pull request Jun 29, 2023
Merged
auto-submit bot pushed a commit that referenced this pull request Jun 30, 2023
@HansMuller
Updated some golden image tests for M2/M3 (#129794)
26ad4a4 
Updated some of the golden image tests that were temporarily changed in #128914 to have M2 and M3 versions. 

Updated the linear_gradient_0 example to M3 (which will require updating its golden image as well).

More info in #127064
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
c3b2175 Update golden tests (flutter/flutter#128914)
d34f1be
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
c3b2175 Update golden tests (flutter/flutter#128914)
26387fe
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
c3b2175 Update golden tests (flutter/flutter#128914)
7c1fd85
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
c3b2175 Update golden tests (flutter/flutter#128914)
6565ebc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@QuncCccccc @HansMuller